bugGNU Octave - Bugs: bug #48529, [octave forge] (image) compilation...

 
 

bug #48529: [octave forge] (image) compilation warnings under Mac OSX

Submitter:  CarnĂ« Draug <carandraug>
Submitted:  Fri 15 Jul 2016 09:01:49 PM UTC
 
Category:  Octave Forge Package Severity:  3 - Normal
Priority:  5 - Normal Item Group:  None
Status:  None Assigned to:  None
Originator Name:  Billy Schwartz Open/Closed:  * Open
Release:  * other Operating System:  * Mac OS
* Mandatory Fields

Add a New Comment (Rich Markup)
   

Comment Type & Canned Response:
       

 

Thu 10 Mar 2022 10:02:33 PM UTC, comment #2: 

I you want to try this change of abs(), Avinoam, go ahead.

I would be willing and able to test afterwards, if installing and the BISTs of custom_gaussian_smoothing still work properly under Windows and under Linux. (It is probably a good time to do this change now, since we will need to do some testing ahead of the next image package release anyway.)

But I will not be ably to do tests under Mac OS to see if this code change succesfully removed the warning, then. I just have not any Mac machine available for Octave testing. Is someone out there, you could then do the testing under Mac OS?

I am not sure what the last two mentioned warnings under Mac OS are about. This seems to be a second topic, not connected to abs. Do you understand this?

Hartmut <hardy>
Fri 04 Feb 2022 10:47:15 AM UTC, comment #1: 

Should we change abs to std::abs in custom_gaussian_smoothing.cc,
or even to fabs?

Avinoam Kalma <avinoam>
Project Member
Fri 15 Jul 2016 09:01:49 PM UTC, original submission:  

As reported on the mailing list

On 15 July 2016 at 20:48, Billy Schwartz <wkschwartz@gmail.com> wrote:

> To whom it may concern:
>
> This bug regards compiling and isntalling the Forge package Image on Mac OS.
> On June 17, 2016, Mike Miller asked whether anyone could install the Image
> package on Mac OS with the latest version of Octave. On a fresh installation
> of Octave 4.0.3 (using Homebrew) on Mac OS 10.11.5, I was able to compile
> and install the Image package in Octave using the usual "pkg install -forge
> image;" command. However, I received seventy four (74) copies of the
> following error message:
>
>> _custom_gaussian_smoothing_.cc:58:43: warning: using integer absolute
>> value function 'abs' when argument
>>       is of floating point type [-Wabsolute-value]
>>               const octave_idx_type rur = abs (k*(ct*sqrtv2 - st*sqrtv1));
>> // 'rur' means 'row-upper-right'
>>                                           ^
>> _custom_gaussian_smoothing_.cc:58:43: note: use function 'std::abs'
>> instead
>>               const octave_idx_type rur = abs (k*(ct*sqrtv2 - st*sqrtv1));
>> // 'rur' means 'row-upper-right'
>>                                           ^~~
>>                                           std::abs
>
>
> I'm guessing fixing this warning is easy: just use the right type of abs
> function. I also got six error messages like the two below.
>
>> _custom_gaussian_smoothing_.cc:161:22: note: in instantiation of
>> function template specialization
>>       'custom_gaussian_smoothing<Matrix>' requested here
>>       retval.append (custom_gaussian_smoothing<Matrix>(I, lambda1,
>> lambda2, theta));
>

>>
>> _custom_gaussian_smoothing_.cc:209:22: note: in instantiation of
>> function template specialization
>>       'custom_gaussian_smoothing<intNDArray<octave_int<unsigned long long>
>> > >' requested here
>>       retval.append (custom_gaussian_smoothing<uint64NDArray>(I, lambda1,
>> lambda2, theta));

Carnë Draug <carandraug>
Project Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by hardy (Posted a comment)
  • -email is unavailable- added by avinoam (Posted a comment)
  • -email is unavailable- added by avinoam
  • -email is unavailable- added by avinoam
  • -email is unavailable- added by jwe (Updated the item)
  • -email is unavailable- added by carandraug (Submitted the item)
  • -email is unavailable- added by carandraug (OP on the mailing list)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only project members can vote.

     

     

     

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2022-02-04 avinoam Carbon-Copy- Added hardy
        Carbon-Copy- Added mmuetzel
    2017-08-13 jwe Summaryimage package: compilation warnings under Mac OSX [octave forge] (image) compilation warnings under Mac OSX
    2016-07-15 carandraug Carbon-Copy- Added -email is unavailable-

    Back to the top


    Powered by Savane 3.9