bugGNU nano - Bugs: bug #48262, when CFLAGS contains -Werror,...

 
 

bug #48262: when CFLAGS contains -Werror, ./configure fails to detect some functions

Submitted by:  Benno Schulenberg <bens>
Submitted on:  Sat 18 Jun 2016 02:03:42 PM UTC  
 
Severity: 3 - NormalStatus: Wont Fix
Assigned to: Benno Schulenberg <bens>Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Wed 29 Jun 2016 01:31:00 PM UTC, comment #3:

Apparently it is not a good idea to have -Werror in your global CFLAGS. See https://lists.gnu.org/archive/html/nano-devel/2016-06/msg00116.html. Other packages (like grep, for example) don't filter out or disarm -Werror during ./configure either, so there is little point in nano doing so.

Benno Schulenberg <bens>
Project AdministratorIn charge of this item.
Tue 21 Jun 2016 04:03:42 PM UTC, comment #2:

adding -Werror to your compiler settings and then running configure is wrong and unsupported. this isn't supported by really any autotools project.

Mike Frysinger <vapier>
Project Member
Tue 21 Jun 2016 10:23:52 AM UTC, comment #1:

Proposed patch.

(file #37535)

Benno Schulenberg <bens>
Project AdministratorIn charge of this item.
Sat 18 Jun 2016 02:03:42 PM UTC, original submission:

To reproduce, run these two commands:

CFLAGS="" ./configure >blank 2>&1
CFLAGS="-Werror" ./configure >werror 2>&1

Then look at 'diff blank werror | less', which shows this:

87,88c87,88
< checking for isblank... yes
< checking for strcasecmp... yes
---

> checking for isblank... no
> checking for strcasecmp... no

90c90
< checking for strncasecmp... yes
---

> checking for strncasecmp... no

92,97c92,97
< checking for snprintf... yes
< checking for vsnprintf... yes
< checking for iswalnum... yes
< checking for iswblank... yes
< checking for iswpunct... yes
< checking for iswspace... yes
---

> checking for snprintf... no
> checking for vsnprintf... no
> checking for iswalnum... no
> checking for iswblank... no
> checking for iswpunct... no
> checking for iswspace... no

103a104,107

> checking for pkg-config... /usr/local/bin/pkg-config
> checking for GLIB - version >= 2.0.0... yes (version 2.24.1)
> checking for pkg-config... (cached) /usr/local/bin/pkg-config
> checking for GLIB - version >= 2.0.0... yes (version 2.24.1)

106,107c110
< checking for vprintf... yes
< checking for _doprnt... no
---

> checking for vprintf... no

117a121,126

> configure: WARNING:
> *** Insufficient UTF-8 support was detected in your curses and/or C
> *** libraries. If you want UTF-8 support, please verify that your slang
> *** was built with UTF-8 support or your curses was built with wide
> *** character support, and that your C library was built with wide
> *** character support.

119,120c128,131
< checking for GNU-style word boundary regex support... yes
< checking whether _XOPEN_SOURCE_EXTENDED is needed... no
---

> checking for GNU-style word boundary regex support... no
> checking whether _XOPEN_SOURCE_EXTENDED is needed... not sure
> configure: WARNING: *** Couldn't successfully compile basic color test with or without _XOPEN_SOURCE_EXTENDED
> configure: WARNING: *** This build may not compile. Consider configuring with --disable-color or installing ncurses


Compilation then fails with this:

In file included from chars.c:26:
/usr/include/ctype.h:128: error: conflicting types for ‘nisblank’
proto.h:176: note: previous declaration of ‘nisblank’ was here
make[2]: *** [chars.o] Error 1

Benno Schulenberg <bens>
Project AdministratorIn charge of this item.

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by vapier (Posted a comment)
  • -unavailable- added by bens (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 6 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sat 30 Jul 2016 09:30:58 AM UTCbensOpen/ClosedOpen=>Closed
    Wed 29 Jun 2016 01:31:00 PM UTCbensStatusIn Progress=>Wont Fix
    Tue 21 Jun 2016 10:23:52 AM UTCbensAttached File-=>Added 0001-build-prevent-Werror-from-interfering-with-configure.patch, #37535
      StatusNone=>In Progress
      Assigned toNone=>bens
    Mon 20 Jun 2016 10:38:20 AM UTCbensSummarywhen CFLAGS contains -Werror, ./configure fails to detect curses=>when CFLAGS contains -Werror, ./configure fails to detect some functions

    Back to the top


    Powered by Savane 3.1-cleanup1