bugGNU Octave - Bugs: bug #48218, function "conv" missing...

 
 

bug #48218: function "conv" missing documentation for shape "valid"

Submitter:  None
Submitted:  Tue 14 Jun 2016 03:31:36 AM UTC
   
 
Category:  Documentation Severity:  2 - Minor
Priority:  3 - Low Item Group:  Documentation
Status:  Fixed Assigned to:  None
Originator Name:  Originator Email:  -email is unavailable-
Open/Closed:  * Closed Release:  * 4.2.0
Operating System:  * Any Fixed Release:  None
Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Jump to the original submission

Fri 08 Sep 2017 04:10:42 PM UTC, comment #6: 

I fixed up the spacing and changed the wording slightly for the sentence that was moved to the "full" table entry, pushed on default here

https://hg.savannah.gnu.org/hgweb/octave/rev/7dec20b876d6

Thanks for the patch.

Mike Miller <mtmiller>
Group Member
Wed 06 Sep 2017 08:23:11 PM UTC, comment #5: 

patch had an odd "Add help for shape = omake Octave better" line up in the commit message. stripped it out of this one. Otherwise patch still applies just fine.



(file #41746)

Nicholas Jankowski <nrjank>
Group Member
Wed 23 Aug 2017 08:51:32 AM UTC, comment #4: 

Ping...

Please review the changeset fro comment #3

Avinoam Kalma <avinoam>
Group Member
Sun 11 Dec 2016 10:11:07 PM UTC, comment #3: 

Please review the attached changeset


(file #39199)

Avinoam Kalma <avinoam>
Group Member
Tue 14 Jun 2016 04:11:19 PM UTC, comment #2: 

To make the patch you can probably grab the text from convn() which is located in libinterp/corefcn/conv2.cc


     SHAPE = "valid"
          Return only the parts which do not include zero-padded edges.
          The size of the result is 'max (size (A) - size (B) + 1, 0)'.



Rik <rik5>
Group administrator
Tue 14 Jun 2016 02:27:02 PM UTC, comment #1: 

Thanks for the report, can you provide a documentation patch against conv.m?

Mike Miller <mtmiller>
Group Member
Tue 14 Jun 2016 03:31:36 AM UTC, original submission:  

In the file conv.m
the third argument SHAPE can be "full", "same", or "valid",
but only "full" and "same" are documented, missing "valid".

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #41746:  conv_v2.diff added by nrjank (2KiB - application/octet-stream)
file #39199:  conv.diff added by avinoam (2KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by nrjank (Updated the item)
  • -email is unavailable- added by avinoam (Updated the item)
  • -email is unavailable- added by mtmiller (Posted a comment)
  • -email is unavailable- added by None (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 13 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2017-09-08 mtmiller StatusPatch Submitted Fixed
        Open/ClosedOpen Closed
    2017-09-06 nrjank Attached File- Added conv_v2.diff, #41746
    2016-12-11 avinoam Attached File- Added conv.diff, #39199
        StatusConfirmed Patch Submitted
        Release4.0.2 4.2.0
    2016-06-14 rik5 Carbon-CopyRemoved 72865 -
    2016-06-14 rik5 CategoryOctave Function Documentation
        StatusNone Confirmed
        Summaryfunction &quot;conv&quot; miss document for shape &quot;valid&quot; function "conv" missing documentation for shape "valid"
    2016-06-14 mtmiller Severity3 - Normal 2 - Minor
        Priority5 - Normal 3 - Low
        Operating SystemGNU/Linux Any

    Back to the top

    Powered by Savane 3.13-758e.
    Corresponding source code