bugGNU Octave - Bugs: bug #48218, function "conv" missing...

 
 

bug #48218: function "conv" missing documentation for shape "valid"

Submitted by:  None
Submitted on:  Tue 14 Jun 2016 03:31:36 AM UTC  
 
Category: DocumentationSeverity: 2 - Minor
Priority: 3 - LowItem Group: Documentation
Status: FixedAssigned to: None
Originator Name: Originator Email: -unavailable-
Open/Closed: ClosedRelease: 4.2.0
Operating System: Any

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Fri 08 Sep 2017 04:10:42 PM UTC, comment #6:

I fixed up the spacing and changed the wording slightly for the sentence that was moved to the "full" table entry, pushed on default here

https://hg.savannah.gnu.org/hgweb/octave/rev/7dec20b876d6

Thanks for the patch.

Mike Miller <mtmiller>
Project Administrator
Wed 06 Sep 2017 08:23:11 PM UTC, comment #5:

patch had an odd "Add help for shape = omake Octave better" line up in the commit message. stripped it out of this one. Otherwise patch still applies just fine.

(file #41746)

Nicholas Jankowski <nrjank>
Wed 23 Aug 2017 08:51:32 AM UTC, comment #4:

Ping...

Please review the changeset fro comment #3

Avinoam Kalma <avinoam>
Project Member
Sun 11 Dec 2016 10:11:07 PM UTC, comment #3:

Please review the attached changeset

(file #39199)

Avinoam Kalma <avinoam>
Project Member
Tue 14 Jun 2016 04:11:19 PM UTC, comment #2:

To make the patch you can probably grab the text from convn() which is located in libinterp/corefcn/conv2.cc

Rik <rik5>
Project Administrator
Tue 14 Jun 2016 02:27:02 PM UTC, comment #1:

Thanks for the report, can you provide a documentation patch against conv.m?

Mike Miller <mtmiller>
Project Administrator
Tue 14 Jun 2016 03:31:36 AM UTC, original submission:

In the file conv.m
the third argument SHAPE can be "full", "same", or "valid",
but only "full" and "same" are documented, missing "valid".

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #41746:  conv_v2.diff added by nrjank (2KiB - application/octet-stream)
file #39199:  conv.diff added by avinoam (2KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by nrjank (Updated the item)
  • -unavailable- added by avinoam (Updated the item)
  • -unavailable- added by mtmiller (Posted a comment)
  • -unavailable- added by None (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 13 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Fri 08 Sep 2017 04:10:42 PM UTCmtmillerStatusPatch Submitted=>Fixed
      Open/ClosedOpen=>Closed
    Wed 06 Sep 2017 08:23:11 PM UTCnrjankAttached File-=>Added conv_v2.diff, #41746
    Sun 11 Dec 2016 10:11:07 PM UTCavinoamAttached File-=>Added conv.diff, #39199
      StatusConfirmed=>Patch Submitted
      Release4.0.2=>4.2.0
    Tue 14 Jun 2016 04:11:35 PM UTCrik5Carbon-CopyRemoved 72865=>-
    Tue 14 Jun 2016 04:11:19 PM UTCrik5CategoryOctave Function=>Documentation
      StatusNone=>Confirmed
      Summaryfunction "conv" miss document for shape "valid"=>function "conv" missing documentation for shape "valid"
    Tue 14 Jun 2016 02:27:02 PM UTCmtmillerSeverity3 - Normal=>2 - Minor
      Priority5 - Normal=>3 - Low
      Operating SystemGNU/Linux=>Any

    Back to the top


    Powered by Savane 3.1-cleanup1