bugGNU Octave - Bugs: bug #48106, Image package: error in make clean

 
 

bug #48106: Image package: error in make clean

Submitted by:  Avinoam Kalma <avinoam>
Submitted on:  Fri 03 Jun 2016 06:15:40 AM UTC  
 
Category: Octave Forge PackageSeverity: 2 - Minor
Priority: 3 - LowItem Group: Incorrect Result
Status: FixedAssigned to: None
Originator Name: AvinoamOpen/Closed: Closed
Release: devOperating System: Any

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sat 04 Jun 2016 07:45:10 PM UTC, comment #2:

Thank you Mike. I have pushed your fix for the clean logic.

http://hg.code.sf.net/p/octave/image/rev/28deaa12353d

However, for the missing im2double I used greps -s flag which is more specific for missing files. I understand that it's not as portable, but I'm already using -Po options.

http://hg.code.sf.net/p/octave/image/rev/f9ef5ea753ef

Carnë Draug <carandraug>
Project Member
Fri 03 Jun 2016 06:56:45 PM UTC, comment #1:

There are two separate unrelated issues here, and neither of them are really that problematic.

The error message about src/im2double.m can be safely ignored, but it could also be silenced with a small patch.

The error when you try to run `make clean` is because you haven't run `make all` yet, so there is no file `src/Makefile`. The fix for this is also simple, just invert the test logic.

I've pushed changesets fixing these two issues to bitbucket, one on the stable branch and on on default. Carnë please pull or adapt as you like into your repository.

https://bitbucket.org/mtmiller/octave-image/commits/28deaa12353d
https://bitbucket.org/mtmiller/octave-image/commits/c2c48bf422f1

Mike Miller <mtmiller>
Project Administrator
Fri 03 Jun 2016 06:15:40 AM UTC, original submission:

note the lines
grep: src/im2double.m: No such file or directory

and the error at the end

Avinoam Kalma <avinoam>
Project Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by mtmiller (Posted a comment)
  • -unavailable- added by mtmiller
  • -unavailable- added by avinoam (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 8 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sat 04 Jun 2016 07:45:10 PM UTCcarandraugStatusPatch Submitted=>Fixed
      Open/ClosedOpen=>Closed
    Fri 03 Jun 2016 06:56:45 PM UTCmtmillerSeverity3 - Normal=>2 - Minor
      Priority5 - Normal=>3 - Low
      Item GroupRegression=>Incorrect Result
      StatusNone=>Patch Submitted
      Operating SystemGNU/Linux=>Any
      Carbon-Copy-=>Added carandraug

    Back to the top


    Powered by Savane 3.1-cleanup1