bugGNU nano - Bugs: bug #48099, the BACK undo item isn't setting...

 
 

bug #48099: the BACK undo item isn't setting undo->newsize to a reasonable value

Submitted by:  Mike Scalora <mscalora>
Submitted on:  Thu 02 Jun 2016 01:31:36 PM UTC  
 
Severity: 3 - NormalStatus: Fixed
Assigned to: Benno Schulenberg <bens>Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Mon 20 Jun 2016 10:13:48 AM UTC, comment #3:

Closing, as the fix was released.

Benno Schulenberg <bens>
Project AdministratorIn charge of this item.
Sat 04 Jun 2016 09:42:14 AM UTC, comment #2:

Fixed in git, edf230b.

Thanks for reporting.

Benno Schulenberg <bens>
Project AdministratorIn charge of this item.
Fri 03 Jun 2016 07:54:54 PM UTC, comment #1:

Hmm. It's not setting newsize at all -- when Backspace or Delete cause two lines to join, it only does an add_undo(), never an update_undo(), and it is the latter that sets newsize. Will fix that.

(Looking forward to the stack visualizer, as a separate patch.)

Benno Schulenberg <bens>
Project AdministratorIn charge of this item.
Thu 02 Jun 2016 01:31:36 PM UTC, original submission:

When using my handy-dandy UNDO stack visualizer with my undo-indent work I noticed that BACK it putting bogus values in undo->newsize:

UNDO 2[136 B]: ENTER line=3 x=4 was=14 new=15 str=""
UNDO 3[136 B]: ADD line=3 x=3 was=13 new=14 str="z"
UNDO 4[136 B]: BACK line=3 x=3 was=14 new=-8070450532247928832 str="c"
UNDO 5[136 B]: ADD line=3 x=0 was=10 new=14 str=" c"
UNDO 6[136 B]: BACK line=3 x=0 was=11 new=140601333908336 str=" "
UNDO 7[136 B]: ADD line=3 x=0 was=10 new=11 str=" "
UNDO 8[136 B]: ADD line=2 x=0 was=8 new=9 str=" "
UNDO 9[136 B]: ADD line=2 x=0 was=6 new=8 str=" c"
UNDO 10[136 B]: ENTER line=1 x=4 was=5 new=6 str=""
UNDO 11[136 B]: ADD line=1 x=0 was=1 new=5 str="dfsg"

-Mike

Mike Scalora <mscalora>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by bens (Posted a comment)
  • -unavailable- added by mscalora (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 4 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Mon 20 Jun 2016 10:13:48 AM UTCbensOpen/ClosedOpen=>Closed
    Sat 04 Jun 2016 09:42:14 AM UTCbensStatusNone=>Fixed
    Fri 03 Jun 2016 07:54:54 PM UTCbensAssigned toNone=>bens
      SummaryThe BACK undo item isn't setting undo->newsize to a reasonable value=>the BACK undo item isn't setting undo->newsize to a reasonable value

    Back to the top


    Powered by Savane 3.1-cleanup1