bugGNU Octave - Bugs: bug #48096, pkg/private/build.m doesn't handle...

 
 

bug #48096: pkg/private/build.m doesn't handle package tar without directory entries

Submitted by:  marco atzeri <matzeri>
Submitted on:  Thu 02 Jun 2016 12:31:06 PM UTC  
 
Category: Octave FunctionSeverity: 4 - Important
Priority: 5 - NormalItem Group: Regression
Status: FixedAssigned to: None
Originator Name: Open/Closed: Closed
Release: devOperating System: Any

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sun 19 Jun 2016 03:20:51 AM UTC, comment #2:

The fix trigger an issue with copyfile (via gzip) though (no error, but prints this warning):

Carnë Draug <carandraug>
Project Member
Sun 19 Jun 2016 03:19:29 AM UTC, comment #1:

I pushed a modified cset. It avoids an anonymous function in cellfun (regexp accepts a cell array, and then cellfun with 'isempty' has a specialied codepath). Also, take into account that it is possible to be other files named DESCRIPTION in the package so we use the one with the smallest path.

See http://hg.savannah.gnu.org/hgweb/octave/rev/f0303b64e59a

I forgot to mention this on the commit message but I replaced the copyright, not because of this path but because I rewrote this whole function some months ago http://hg.savannah.gnu.org/hgweb/octave/rev/2ee20a290d61

Carnë Draug <carandraug>
Project Member
Thu 02 Jun 2016 12:31:06 PM UTC, original submission:

As discussed on:

http://lists.gnu.org/archive/html/octave-maintainers/2016-05/msg00318.html
http://lists.gnu.org/archive/html/octave-maintainers/2016-06/msg00001.html

"pkg build" fails for some type of tar files.

It is due to changeset
http://hg.savannah.gnu.org/hgweb/octave/rev/2ee20a290d61

that assumes that all tar files has directory entries

generate_html-0.1.11/
generate_html.0.1.11/COPYING
generate_html.0.1.11/DESCRIPTION
generate_html.0.1.11/INDEX
generate_html.0.1.11/NEWS
generate_html-0.1.11/inst/
..

but can not manage when only files are present:

generate_html.0.1.11/COPYING
generate_html.0.1.11/DESCRIPTION
generate_html.0.1.11/INDEX
generate_html.0.1.11/NEWS
generate_html.0.1.11/inst/generate_html_manual.m
...

Attached patch to solve the issue.
Better formulation is likely possible.

marco atzeri <matzeri>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #37354:  build.m.patch added by matzeri (685B - text/x-diff)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by mtmiller (Updated the item)
  • -unavailable- added by siko1056 (Updated the item)
  • -unavailable- added by matzeri (Submitted the item)
  • -unavailable- added by matzeri
  • -unavailable- added by matzeri
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 8 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sun 19 Jun 2016 03:19:29 AM UTCcarandraugStatusPatch Submitted=>Fixed
      Open/ClosedOpen=>Closed
    Thu 02 Jun 2016 10:45:04 PM UTCmtmillerSeverity3 - Normal=>4 - Important
      Summarybuild.m doesn't handle package tar without directory entries=>pkg/private/build.m doesn't handle package tar without directory entries
    Thu 02 Jun 2016 01:45:15 PM UTCsiko1056StatusNone=>Patch Submitted
    Thu 02 Jun 2016 12:31:06 PM UTCmatzeriAttached File-=>Added build.m.patch, #37354
      Carbon-Copy-=>Added -unavailable-
      Carbon-Copy-=>Added -unavailable-

    Back to the top


    Powered by Savane 3.1-cleanup1