bugGNU Octave - Bugs: bug #48044, Searching for markers does not wrap

 
 

bug #48044: Searching for markers does not wrap

Submitted by:  Lachlan Andrew <lachlan>
Submitted on:  Sat 28 May 2016 10:05:46 AM UTC  
 
Category: GUISeverity: 1 - Wish
Priority: 5 - NormalItem Group: Incorrect Result
Status: FixedAssigned to: Lachlan Andrew <lachlan>
Originator Name: LachlanOpen/Closed: Closed
Release: devOperating System: GNU/Linux

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Mon 25 Jul 2016 11:32:22 PM UTC, comment #2:

I pushed this changeset here:

http://hg.savannah.gnu.org/hgweb/octave/rev/603f0d752de2

Closing report.

Thanks!

John W. Eaton <jwe>
Project Administrator
Sat 28 May 2016 10:10:02 AM UTC, comment #1:

Here's the patch

(file #37295)

Lachlan Andrew <lachlan>
Project MemberIn charge of this item.
Sat 28 May 2016 10:05:46 AM UTC, original submission:

The keys F2 and shift+F2 do not cause the search for markers to wrap around the end of the file.

This is annoying since the point of markers is to be able to get to them without knowing where you are coming from.

The patch is straightforward, and I'll attach it once I have the bug number. It also changes the menu order to "Next Bookmark" then "Previous Bookmark", which seems more natural, as well as being alphabetical and giving the non-shift version before the shift+ version.

Lachlan Andrew <lachlan>
Project MemberIn charge of this item.

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by jwe (Posted a comment)
  • -unavailable- added by lachlan (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 5 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Mon 25 Jul 2016 11:32:22 PM UTCjweStatusPatch Submitted=>Fixed
      Open/ClosedOpen=>Closed
    Sat 28 May 2016 10:10:29 AM UTClachlanStatusNone=>Patch Submitted
      Assigned toNone=>lachlan
    Sat 28 May 2016 10:10:02 AM UTClachlanAttached File-=>Added bug_48044_wrap_markers.cset, #37295

    Back to the top


    Powered by Savane 3.1-cleanup1