bugGNU Octave - Bugs: bug #48033, gnuplot toolkit uses features not...

 
 

bug #48033: gnuplot toolkit uses features not available in gnuplot 4

Submitted by:  Mike Miller <mtmiller>
Submitted on:  Thu 26 May 2016 06:41:06 PM UTC  
 
Category:  Plotting with gnuplot Severity:  3 - Normal
Priority:  3 - Low Item Group:  Regression
Status:  Fixed Assigned to:  None
Originator Name:  Open/Closed:  Closed
Release:  dev Operating System:  GNU/Linux

Add a New Comment (Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

( Jump to the original submission)

Tue 06 Sep 2016 12:26:32 AM UTC, comment #13: 

I think linestyles have now been fixed in Octave back to at least gnuplot 4.4.  Closing report.

Rik <rik5>
Project Administrator
Sat 20 Aug 2016 11:09:13 PM UTC, comment #12: 

I really think that for 4.2 release we may require gnuplot 5.x or newer. If people are capable to compile a newer octave they should be able to compile a newer gnuplot.

Dmitri.
--

Dmitri A. Sergatskov <dasergatskov>
Thu 07 Jul 2016 04:51:45 PM UTC, comment #11: 

This is the one I remember now I was going to get back to.  Let me finish up a few of the other gnuplot issues since we're on a roll with those, then I'll revisit this one.

Dan Sebald <sebald>
Thu 07 Jul 2016 04:36:15 PM UTC, comment #10: 

Raising the severity of this to Blocker for the 4.2 release.  We should just decide what we're going to do here and either warn the user, or cut off using gnuplot < 5.

Rik <rik5>
Project Administrator
Thu 07 Jul 2016 04:07:01 PM UTC, comment #9: 

Retitling and adding more details to reflect that further changes have made certain features not work in gnuplot 4.6 as well. Error messages are not produced, so it's not as severe as with gnuplot 4.4, but several linestyle options do not work (that do work with gnuplot 5), grid lines show up as solid lines now (they were correct in earlier versions of Octave with gnuplot 4).

It seems that more work is being done on better support with gnuplot 5, which is a good thing, but if we are going to write off gnuplot 4, we should make that explicit and provide the user with an error message.

Mike Miller <mtmiller>
Project Administrator
Sat 11 Jun 2016 12:58:56 AM UTC, comment #8: 

By the way I don't care if we require a new version of gnuplot now, I just want that to be made explicit so the correct error message is shown to the user if that's the decision.

The code now claims that it will work with gnuplot 4.4 and that is now not true.

Mike Miller <mtmiller>
Project Administrator
Sat 11 Jun 2016 12:57:07 AM UTC, comment #7: 

No, it is now broken with the following error:

>> plot (1:10)

gnuplot> plot "-" binary format='%float64' record=10 using ($1):($2) axes x1y1 title "" with  linestyle 9 ;
                                                                                                        ^
         line 0: expecting 'lines', 'points', 'linespoints', 'dots', 'impulses',
        'yerrorbars', 'xerrorbars', 'xyerrorbars', 'steps', 'fs


Mike Miller <mtmiller>
Project Administrator
Fri 10 Jun 2016 10:28:51 PM UTC, comment #6: 

@Mike: Could you test the original problem with gnuplot 4.4 using cset 21853:09583900661b.  I had to reverse part of Dan's patch for this bug in order to solve bug #48198.

Rik <rik5>
Project Administrator
Thu 02 Jun 2016 09:45:32 PM UTC, comment #5: 

I pushed Dan's patch for ancient gnuplot 4.4 here (http://hg.savannah.gnu.org/hgweb/octave/rev/b2f1f4cf1389).

Fixed.  Closing report.

Rik <rik5>
Project Administrator
Mon 30 May 2016 07:49:18 AM UTC, comment #4: 

Yes, looks like I conflated "linestyle" and "style line" to come up with "line style".  Your change for the fix shouldn't be done in gnuplot_linetype(), however.  That's a lower level routine and if there is no linetype support, it shouldn't indicate there is.  Attached is a better place to fix the missing style of

title "" with  linestyle 9 ;

[There are two whitespaces between 'with' and 'linestyle' where the missing "lines" should be.]  Give it a try.  Change to your name for contributor if you like.

(file #37306)

Dan Sebald <sebald>
Fri 27 May 2016 12:49:31 AM UTC, comment #3: 

The attached diff fixes all of the problems I have seen since the aforementioned patch was applied. It looks to me like these were just little typos or points of confusion in the whole transition from line style to linetype or dashtype, etc.

Someone who knows gnuplot better than me should look this over.

(file #37282)

Mike Miller <mtmiller>
Project Administrator
Fri 27 May 2016 12:31:59 AM UTC, comment #2: 

Thanks, yes, that is pretty much the same error. I am the one who closed that bug as "works for me" but forgot about it until now.

Here's a correction to the output I am seeing:

octave:4> plot (1:10);

gnuplot> set line style 9 default;
             ^
         line 0: Unrecognized option.  See 'help set'.


gnuplot> set line style 9 linecolor rgb "#0000ff" linewidth 0.500000;
             ^
         line 0: Unrecognized option.  See 'help set'.


gnuplot> set line style 9 default;
             ^
         line 0: Unrecognized option.  See 'help set'.


gnuplot> set line style 9 linecolor rgb "#0000ff" pointsize 2.000000;
             ^
         line 0: Unrecognized option.  See 'help set'.


gnuplot> plot "-" binary format='%float64' record=10 using ($1):($2) axes x1y1 title "" with  linestyle 9 ;
                                                                                                        ^
         line 0: expecting 'lines', 'points', 'linespoints', 'dots', 'impulses',
        'yerrorbars', 'xerrorbars', 'xyerrorbars', 'steps', 'fs


So the feature test for "linetype" looks like it is working, but "line style" is an error. The code used to use "style line", so I corrected that and got a little further. Now the error is:

octave:2> plot (1:10);

gnuplot> plot "-" binary format='%float64' record=10 using ($1):($2) axes x1y1 title "" with  linestyle 9 ;
                                                                                                        ^
         line 0: expecting 'lines', 'points', 'linespoints', 'dots', 'impulses',
        'yerrorbars', 'xerrorbars', 'xyerrorbars', 'steps', 'fs

The stable branch works with gnuplot 4.4, so this only affects default, and probably due to http://hg.savannah.gnu.org/hgweb/octave/rev/21c3641422e0.

Mike Miller <mtmiller>
Project Administrator
Thu 26 May 2016 09:13:42 PM UTC, comment #1: 
Anonymous
Thu 26 May 2016 06:41:06 PM UTC, original submission:  

Running some plot demos with (yes, ancient version of) gnuplot 4.4 throws a lot of errors of the type:

>> plot (1:10)

gnuplot> set linetype 9 default;
             ^
         line 0: Unrecognized option.  See 'help set'.


gnuplot> set linetype 9 linecolor rgb "#0000ff" dashtype solid linewidth 0.500000;
             ^
         line 0: Unrecognized option.  See 'help set'.


gnuplot> set linetype 10 default;
             ^
         line 0: Unrecognized option.  See 'help set'.


gnuplot> set linetype 10 linecolor rgb "#0000ff" pointsize 2.000000;
             ^
         line 0: Unrecognized option.  See 'help set'.

I see there are various version and feature checks in place in the gnuplot m-files, but apparently the code has now advanced beyond what this is checking for.

If there are certain features that can be used or not used, we need more checks for those. If this "set linetype" needs to be used everywhere (I see it on every plot I try), then we need a check for whatever version introduced that feature.

There is already a "minimum_version" feature, which is currently testing for gnuplot >= 4.2.5.

Mike Miller <mtmiller>
Project Administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #37282:  gp44.diff added by mtmiller (1KiB - text/x-diff)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by dasergatskov (Posted a comment)
  • -email is unavailable- added by rik5 (Posted a comment)
  • -email is unavailable- added by sebald (Updated the item)
  • -email is unavailable- added by rik5
  • -email is unavailable- added by mtmiller (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

     

     

    Follow 16 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2016-09-06 rik5 Severity5 - Blocker => 3 - Normal
        StatusIn Progress => Fixed
        Open/ClosedOpen => Closed
    2016-07-07 rik5 Severity3 - Normal => 5 - Blocker
    2016-07-07 mtmiller Item GroupIncorrect Result => Regression
        Summarygnuplot toolkit uses features not available in gnuplot 4.4 => gnuplot toolkit uses features not available in gnuplot 4
    2016-06-11 mtmiller StatusFixed => In Progress
        Open/ClosedClosed => Open
    2016-06-02 rik5 StatusPatch Submitted => Fixed
        Open/ClosedOpen => Closed
    2016-05-30 sebald Attached File- => Added octave-gnuplot_older_linestyle-djs2016may29.patch, #37306
    2016-05-27 rik5 Carbon-Copy- => Added sebald
    2016-05-27 mtmiller Attached File- => Added gp44.diff, #37282
        StatusConfirmed => Patch Submitted
    2016-05-27 mtmiller StatusNone => Confirmed
    2016-05-27 mtmiller Priority5 - Normal => 3 - Low

    Back to the top


    Powered by Savane 3.5