bugPSPP - Bugs: bug #48015, Bug in gui Independent Samples GUI

 
 

bug #48015: Bug in gui Independent Samples GUI

Submitted by:  Harry Thijssen <unknown_one>
Submitted on:  Wed 25 May 2016 02:26:42 PM UTC  
 
Category: Graphical User InterfaceSeverity: 5 - Average
Status: FixedAssigned to: None
Open/Closed: ClosedRelease: None
Effort: 0.00

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Mon 06 Jun 2016 04:20:28 PM UTC, comment #11:

I think this has been fixed now.

John Darrington <jmd>
Project Administrator
Sat 28 May 2016 12:36:48 PM UTC, comment #10:

Hi John

After your coomit it doesn crash anymore in the situation like before.

Harry Thijssen <unknown_one>
Sat 28 May 2016 11:45:51 AM UTC, comment #9:

Hi John,

with your commit eed5852df052914a45dc2e241 psppire does not crash with long and short string variables as group variables on MacOS when doing the independent samples test via gui.

Selecting a variable to the group entry field, does not remove the variable from the list of variables. Is this how it is supposed to be?

Friedrich

Friedrich Beckmann <beckmanf>
Project Member
Sat 28 May 2016 06:05:57 AM UTC, comment #8:

I pushed a change which should improve things.

Please give it a thorough test.

John Darrington <jmd>
Project Administrator
Fri 27 May 2016 06:56:51 PM UTC, comment #7:

Hi the output on a dbg session I did on MSWindows:

Program received signal SIGSEGV, Segmentation fault.
0x0058695c in var_get_type (v=0x0) at src/data/variable.c:239
warning: Source file is more recent than executable.
239 return val_type_from_width (v->width);
(gdb) backtrace
#0 0x0058695c in var_get_type (v=0x0) at src/data/variable.c:239
#1 0x00586b52 in var_is_numeric (v=0x0) at src/data/variable.c:330
#2 0x00455f61 in run_define_groups (act=0x3b51048)
at src/ui/gui/psppire-dialog-action-indep-samps.c:163
#3 0x63c4604a in ?? ()
from C:\Program Files (x86)\PSPP\bin\libgobject-2.0-0.dll
(gdb)

Hope this helps

Harry Thijssen <unknown_one>
Fri 27 May 2016 01:36:51 PM UTC, comment #6:

Hi John,

i also had a look at the code. The immediate problem is the assumption of short strings in the grp_val in psppire-dialog-action-indep-samps.c:

To crash psppire, the group variable has to be a string with length such that short_string is not used.

I noticed an additional problem:

The variable that is selected as group variable is not removed from the left treeview. I think this is coded in the selector code where there is probably a difference between treeview -> treeview and treeview->entry.

Then you can select a variable as group variable and as test variable, is this o.k.?

Friedrich

Friedrich Beckmann <beckmanf>
Project Member
Fri 27 May 2016 05:01:38 AM UTC, comment #5:

Thanks for this backtrace.

Now that I look at this code I see that it is written rather naively.

I will try to improve it in the next few days.

John Darrington <jmd>
Project Administrator
Thu 26 May 2016 02:04:32 PM UTC, comment #4:

This is the backtrace on MacOS when I click on the remove "sex" variable in the t-test dialog.

Friedrich Beckmann <beckmanf>
Project Member
Thu 26 May 2016 01:42:50 PM UTC, comment #3:

The bug is also in the 0.10.1 released version.

Friedrich Beckmann <beckmanf>
Project Member
Thu 26 May 2016 01:32:41 PM UTC, comment #2:

The bug is is reproducible on MacOS in the current git

To see the problem do:

then go to gui: Analyze->Compare average->T-Test for independent samples

Choose weight for testvariable
Choose sex for Groupvariable

-> Ok Button is still gray

Click in GroupVariable
Click on Remove Variable
->psppire crashes

The error message is:

Friedrich Beckmann <beckmanf>
Project Member
Wed 25 May 2016 06:23:47 PM UTC, comment #1:

Can you try to get a backtrace using your debug version.

John Darrington <jmd>
Project Administrator
Wed 25 May 2016 02:26:42 PM UTC, original submission:

In the MSWindows build, with the source 2016-05-25, I get a GUI crash when I click "Define groups" in the Independent Samples T test.

Harry Thijssen <unknown_one>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by jmd
  • -unavailable- added by beckmanf (Posted a comment)
  • -unavailable- added by jmd (Posted a comment)
  • -unavailable- added by unknown_one (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 5 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Mon 06 Jun 2016 04:20:28 PM UTCjmdStatusConfirmed=>Fixed
      Open/ClosedOpen=>Closed
    Fri 27 May 2016 01:14:00 PM UTCjmdSummaryBug in gui Independent Samples T test=>Bug in gui Independent Samples GUI
    Fri 27 May 2016 01:13:42 PM UTCjmdCarbon-Copy-=>Added -unavailable-
    Thu 26 May 2016 01:32:41 PM UTCbeckmanfStatusNone=>Confirmed

    Back to the top


    Powered by Savane 3.1-cleanup1