bugmake - Bugs: bug #48009, Increased stack rlimit is...

 
 

bug #48009: Increased stack rlimit is inherited by the subprocesses to make when make restarts

Submitted by:  Jeremy Devenport <jeremyd>
Submitted on:  Wed 25 May 2016 12:00:19 PM UTC  
 
Severity: 3 - NormalItem Group: Bug
Status: FixedPrivacy: Public
Assigned to: Paul D. Smith <psmith>Open/Closed: Closed
Component Version: 4.2.1Operating System: POSIX-Based
Fixed Release: 4.2.1Triage Status: Small Effort

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Tue 31 May 2016 07:16:31 AM UTC, comment #1:

Fixed for the next release. Thanks for the report.

Paul D. Smith <psmith>
Project AdministratorIn charge of this item.
Wed 25 May 2016 12:00:19 PM UTC, original submission:

The fix for https://savannah.gnu.org/bugs/?22010 is incomplete. When make restarts itself due to an updated makefile it re-exec's itself inheriting the increased stack rlimit but without remembering the original saved values so the re-exec'd make will run its subprocesses with the increased stack limit.

This sequence of commands demonstrates the bug:

$ ulimit -H -s
32768
$ ulimit -s
4096
$ cat Makefile
include foo.inc
foo.inc: bar.txt
touch $@
show-stack-rlimit:
ulimit -s
$ echo > foo.inc
$ echo > bar.txt
$ make show-stack-rlimit
touch foo.inc
ulimit -s
32768 <-- inherited the stack increase to the hard limit
$ make show-stack-rlimit
ulimit -s
4096

The attached patch resolves the issue for me.

Jeremy Devenport <jeremyd>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by psmith (Posted a comment)
  • -unavailable- added by jeremyd (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 6 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Tue 31 May 2016 07:16:31 AM UTCpsmithStatusNone=>Fixed
      Assigned toNone=>psmith
      Open/ClosedOpen=>Closed
      Fixed ReleaseNone=>4.2.1
      Triage StatusNone=>Small Effort
    Wed 25 May 2016 12:00:19 PM UTCjeremydAttached File-=>Added stack-rlimit-make-restart.patch, #37259

    Back to the top


    Powered by Savane 3.1-cleanup1