bugGNU Astronomy Utilities - Bugs: bug #47987, doc/genauthors makes an empty...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #47987: doc/genauthors makes an empty doc/authors.texi in multiple threads

Submitted by:  Mohammad Akhlaghi <makhlaghi>
Submitted on:  Mon 23 May 2016 11:34:55 AM UTC  
 
Category: DevelopmentSeverity: 3 - Normal
Item Group: CrashStatus: Fixed
Privacy: PublicAssigned to: Mohammad Akhlaghi <makhlaghi>
Open/Closed: Closed

Mon 30 May 2016 08:25:11 AM UTC, comment #1:

By setting `authors.texi' as a BUILT_SOURCES in `doc/Makefile.am', it is now built before any other parts of the documentation. Therefore even when `make' is run with multiple threads, `authors.texi' is generated before all other threads of this directory.

This fix has been pushed into master on the main repository.

Mohammad Akhlaghi <makhlaghi>
Project AdministratorIn charge of this item.
Mon 23 May 2016 11:34:55 AM UTC, original submission:

When `make' is called on multiple threads, sometimes the `git shortlog' command in `doc/genauthors' doesn't make any output. Therefore `authors.texi' remains empty.

In commit c5b6cee (Check added to see if doc/authors.texi is empty) a test was added to check if `doc/authors.texi' is empty. If so, `doc/genauthors' exits with a non-zero value (failure). So the building process stops and the user/developer is informed. By running a simple `make' it will be built, and since the documentation is the last part to be built, there won't be any problem with building the libraries and utilities.

However, this is not an elegant solution! We have to find a solution, so `git shortlog' makes an output everytime `make -jN' is run, not randomly.

Mohammad Akhlaghi <makhlaghi>
Project AdministratorIn charge of this item.

 

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by makhlaghi (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 3 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Mon 30 May 2016 08:25:11 AM UTCmakhlaghiStatusConfirmed=>Fixed
      Assigned toNone=>makhlaghi
      Open/ClosedOpen=>Closed

    Back to the top


    Powered by Savane 3.1-cleanup1