bugGNU Octave - Bugs: bug #47961, system.tst fails because...

 
 

bug #47961: system.tst fails because octave::sys::umask is endlessly recursive

Submitted by:  Lachlan Andrew <lachlan>
Submitted on:  Thu 19 May 2016 01:49:21 PM UTC  
 
Category: Octave FunctionSeverity: 3 - Normal
Priority: 5 - NormalItem Group: Regression
Status: FixedAssigned to: None
Originator Name: LachlanOpen/Closed: Closed
Release: devOperating System: GNU/Linux

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Thu 19 May 2016 02:31:38 PM UTC, comment #4:

Thanks both, all looks good here.

Mike Miller <mtmiller>
Project Administrator
Thu 19 May 2016 02:18:41 PM UTC, comment #3:

I applied your patch.

Thanks.

John W. Eaton <jwe>
Project Administrator
Thu 19 May 2016 02:12:49 PM UTC, comment #2:

So we're talking about umask, not uname? :)

Confused before I saw the patch, because I only see ::uname being called.

Testing now.

Mike Miller <mtmiller>
Project Administrator
Thu 19 May 2016 01:56:16 PM UTC, comment #1:

I notice that most functions in file-ops.cc call the gnulib functions, rather than the ones in the global namespace. However, (on my system at least) there is no umask in gnulib, and so the attached patch just calls ::uname.

(file #37208)

Lachlan Andrew <lachlan>
Project Member
Thu 19 May 2016 01:49:21 PM UTC, original submission:

The new function octave::sys::uname calls "uname ()", instead of "::uname".

I'll attach the patch once I have a bug number.

Lachlan Andrew <lachlan>
Project Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #37208:  bug_47961_umask.cset added by lachlan (757B - text/x-diff)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by jwe (Posted a comment)
  • -unavailable- added by mtmiller (Posted a comment)
  • -unavailable- added by lachlan (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 6 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Thu 19 May 2016 02:18:41 PM UTCjweStatusPatch Submitted=>Fixed
      Open/ClosedOpen=>Closed
      Summarysystem.tst fails because octave::sys::uname is endlessly recursive=>system.tst fails because octave::sys::umask is endlessly recursive
    Thu 19 May 2016 02:12:49 PM UTCmtmillerStatusNone=>Patch Submitted
    Thu 19 May 2016 02:00:20 PM UTClachlanSummaryoctave::sys::uname is endlessly recursive=>system.tst fails because octave::sys::uname is endlessly recursive
    Thu 19 May 2016 01:56:16 PM UTClachlanAttached File-=>Added bug_47961_umask.cset, #37208

    Back to the top


    Powered by Savane 3.1-cleanup1