bugGNU Octave - Bugs: bug #47912, __gnuplot_drawnow__.m arguments do...

 
 

bug #47912: __gnuplot_drawnow__.m arguments do not match the calling C arguments

Submitted by:  Dan Sebald <sebald>
Submitted on:  Fri 13 May 2016 08:42:38 AM UTC  
 
Category: Plotting with gnuplotSeverity: 3 - Normal
Priority: 5 - NormalItem Group: Other
Status: FixedAssigned to: None
Originator Name: Open/Closed: Closed
Release: devOperating System: Any

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sat 14 May 2016 04:03:30 AM UTC, comment #3:

I had to make one more change in graphics.in.h to eliminate an instance of mono. Other than that, I pushed your cset here (http://hg.savannah.gnu.org/hgweb/octave/rev/21fdab18f857).

Thanks for the fix. Closing report as done.

Rik <rik5>
Project Administrator
Sat 14 May 2016 12:11:00 AM UTC, comment #2:

I'm attaching a patch file changeset to remove all references to 'mono' throughout the code. The figure/plot and print commands seem to work for all toolkits here. Let me know if they work for you.

(file #37149)

Dan Sebald <sebald>
Fri 13 May 2016 11:03:37 AM UTC, comment #1:

print.m has been modified to handle color/mono. This was already being done for the OpenGL toolkits. To reduce the complexity of the code, the same approach as applied to Gnuplot.

http://hg.savannah.gnu.org/hgweb/octave/rev/5b9618f4f841

The correct fix is to remove the "mono" argument from calls to gnuplot_drawnow.

If someone doesn't get to it first, I'll take a look over the weekend.

Ben Abbott <bpabbott>
Project Member
Fri 13 May 2016 08:42:38 AM UTC, original submission:

The debugging method of

drawnow (TERM, FILE, MONO, DEBUG_FILE)

no longer works, giving the following errors:

The reason for the error is that the _gnuplot_drawnow_.m routine has one fewer input arguments than the calling C code. Here is how I've fixed the problem and I added a comment near the calling code to illustrate the number of input arguments.

There no longer appears to be use of 'mono' in the _gnuplot_drawnow_ routine, so perhaps the intension was to remove the 'mono' and reduce the number of options sent into the routine. That would mean that the print_figure() mono variable is unused.

Dan Sebald <sebald>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by rik5 (Posted a comment)
  • -unavailable- added by bpabbott (Posted a comment)
  • -unavailable- added by sebald (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 3 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sat 14 May 2016 04:03:30 AM UTCrik5StatusNone=>Fixed
      Open/ClosedOpen=>Closed
    Sat 14 May 2016 12:11:00 AM UTCsebaldAttached File-=>Added octave-drawnow-djs2016may13.patch, #37149

    Back to the top


    Powered by Savane 3.1-cleanup1