bugGNU Octave - Bugs: bug #47773, Using depracated octave_idx_type...

 
 

bug #47773: Using depracated octave_idx_type Array<T>::length() in lo-sysdep.cc

Submitted by:  Avinoam Kalma <avinoam>
Submitted on:  Sun 24 Apr 2016 08:28:17 AM UTC  
 
Category: Configuration and Build SystemSeverity: 3 - Normal
Priority: 5 - NormalItem Group: Other
Status: FixedAssigned to: None
Originator Name: AvinoamOpen/Closed: Closed
Release: devOperating System: GNU/Linux

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sun 24 Apr 2016 11:46:53 PM UTC, comment #3:

Thanks Lachlan, this is a good easy fix. I checked it in here (http://hg.savannah.gnu.org/hgweb/octave/rev/da9c75ffd1a3).

I took a look through the other instances of length() in liboctave and they are okay. I do see room for improvement which is to replace dv.length () with dv.ndims () for clarity. But that is unrelated.

Rik <rik5>
Project Administrator
Sun 24 Apr 2016 05:28:28 PM UTC, comment #2:

As it is a mere warning, is it really important to fix urgently?

Philip Nienhuis <philipnienhuis>
Project Member
Sun 24 Apr 2016 01:18:32 PM UTC, comment #1:

The change seems trivial (attached), though I'm not set up to run MXE-octave to check it.

I'm not sure of a fast way to check if there are other cases in conditionally compiled code.

(file #36988)

Lachlan Andrew <lachlan>
Project Member
Sun 24 Apr 2016 08:28:17 AM UTC, original submission:

When compiling MXE-Octave I get the warning:

^

Avinoam Kalma <avinoam>
Project Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by rik5 (Posted a comment)
  • -unavailable- added by lachlan (Updated the item)
  • -unavailable- added by avinoam (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 4 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sun 24 Apr 2016 11:46:53 PM UTCrik5StatusPatch Submitted=>Fixed
      Open/ClosedOpen=>Closed
    Sun 24 Apr 2016 01:18:32 PM UTClachlanAttached File-=>Added bug_47773_deprecated_length.cset, #36988
      StatusNone=>Patch Submitted

    Back to the top


    Powered by Savane 3.1-cleanup1