bugGNU Octave - Bugs: bug #47700, Octave JDialogBox interface uses...

 
 

bug #47700: Octave JDialogBox interface uses deprecated features

Submitted by:  Rik <rik5>
Submitted on:  Thu 14 Apr 2016 10:48:52 PM UTC  
 
Category: Configuration and Build SystemSeverity: 2 - Minor
Priority: 5 - NormalItem Group: Other
Status: FixedAssigned to: Kai Torben Ohlhus <siko1056>
Originator Name: Open/Closed: Closed
Release: devOperating System: Any

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Tue 19 Apr 2016 01:31:37 PM UTC, comment #5:

Done, see cset http://hg.savannah.gnu.org/hgweb/octave/rev/b5d9b95d1e1a

Kai Torben Ohlhus <siko1056>
Project MemberIn charge of this item.
Fri 15 Apr 2016 09:13:43 PM UTC, comment #4:

@Rik: I think I got you right. The post on the mailing list is coming soon.

Kai Torben Ohlhus <siko1056>
Project MemberIn charge of this item.
Fri 15 Apr 2016 05:58:25 PM UTC, comment #3:

@Kai: I don't think I phrased things very well. I think we should get rid of the Java dialog code. I wrote "My biggest objection" and it would have been clearer to write "My biggest objection to supporting Java dialog boxes ...".

Rik <rik5>
Project Administrator
Fri 15 Apr 2016 03:35:02 PM UTC, comment #2:

@Kai: I'm fine with removing the Java dialog boxes. However, could you circulate this idea on the Octave-Maintainer's list just to make sure no one else objects? My biggest objection is that it is a lot of code to maintain for a very small corner case when Qt is not enabled.

Rik <rik5>
Project Administrator
Fri 15 Apr 2016 11:50:29 AM UTC, comment #1:

Maybe we should abandon all Java-dialogs, instead of trying to fix and maintain unused code. There are two concurrent implementations of dialogs (Java and QT). The documentation still mentions only Java:

https://www.gnu.org/software/octave/doc/v4.0.1/Dialog-Box-Functions.html#Dialog-Box-Functions

The concurrency is visible in

scripts/gui/private/message_dialog.m,

where first always the QT variant is tried, thereafter the Java variant. Thus I think no one has ever really seen the Java variant before, as QT works naturally with the GUI.

The java variant is implemented in

scripts/java/org/octave/*.java

the QT variant in

libinterp/corefcn/octave-link.{h/cc}

The only pro for the Java-variant is, that it is able to print some TeX symbols

https://www.gnu.org/software/octave/doc/v4.0.1/Which-TeX-symbols-are-implemented-in-dialog-functions_003f.html

This doesn't apply for the QT-variant, but for me this feature has never been accessible before and it is a minor victim for clarifying the code a lot.

As I don't get negative respone, I will remove the Java-variant with changes to the calling code and documentation.

Kai Torben Ohlhus <siko1056>
Project MemberIn charge of this item.
Thu 14 Apr 2016 10:48:52 PM UTC, original submission:

I found the following new warning when compiling the default branch of Octave.

Someone who knows Java might take a look at the file scripts/java/org/octave/JDialogBox.java and see if they can spot the problem. Or compile the .java file with -Xlint:deprecation as suggested and see if it pinpoints the issue.

I've marked the bug as minor because most dialog boxes now use Qt widgets. It's only when running with Qt libraries that Octave falls back to Java dialog boxes.

Rik <rik5>
Project Administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by siko1056 (Posted a comment)
  • -unavailable- added by rik5 (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 5 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Tue 19 Apr 2016 01:31:37 PM UTCsiko1056StatusNeed Info=>Fixed
      Open/ClosedOpen=>Closed
    Fri 15 Apr 2016 11:50:29 AM UTCsiko1056StatusNone=>Need Info
      Assigned toNone=>siko1056
      Operating SystemGNU/Linux=>Any

    Back to the top


    Powered by Savane 3.1-cleanup1