bugGNU Octave - Bugs: bug #47692, Menu/keyboard actions duplicated...

 
 

bug #47692: Menu/keyboard actions duplicated when <unnamed> is reused

Submitted by:  Lachlan Andrew <lachlan>
Submitted on:  Thu 14 Apr 2016 04:52:04 AM UTC  
 
Category: GUISeverity: 3 - Normal
Priority: 5 - NormalItem Group: Regression
Status: FixedAssigned to: Lachlan Andrew <lachlan>
Originator Name: LachlanOpen/Closed: Closed
Release: devOperating System: GNU/Linux

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Thu 28 Apr 2016 03:37:18 AM UTC, comment #5:

I pushed the cset here (http://hg.savannah.gnu.org/hgweb/octave/rev/7c0595c722ca). Closing report.

Rik <rik5>
Project Administrator
Mon 25 Apr 2016 03:23:18 PM UTC, comment #4:

I also encoutered problems related to this bug (see bug #47777) which are solved by the patch. Found no more problems while extensivly working with the gui for several hours now. Also suggesting to push it.

Lars Kindermann <larskindermann>
Mon 25 Apr 2016 07:29:26 AM UTC, comment #3:

I can reproduce this bug, and the patch indeed solves it.

Please push it.

Avinoam Kalma <avinoam>
Project Member
Thu 21 Apr 2016 09:08:58 PM UTC, comment #2:

I tried an mxe-octave build on Windows with the patch[*]. I can't reproduce the doubled actions, but I don't remember if I ever hit the issue before the patch.
I'll try later on Linux.

[*] I have a build with several of your patches (~7 or so), but lack time for solid testing. Some have been pushed already.

Philip Nienhuis <philipnienhuis>
Project Member
Thu 14 Apr 2016 05:33:08 AM UTC, comment #1:

A fix is attached. The add_file_editor_tab() call was causing the doubling of the connections.

It seems to work, but I'll keep using it on my production system for a while to see if it causes any further problems.

I must test more carefully before submitting patches.
I must test more carefully before submitting patches.
I must test more carefully before submitting patches.
I must test more carefully before submitting patches.

(file #36922)

Lachlan Andrew <lachlan>
Project MemberIn charge of this item.
Thu 14 Apr 2016 04:52:04 AM UTC, original submission:

Patch 08baf0ebc9a9 for bug #47529 appears to have introduced a regression.

If the editor is opened before a file is loaded, it creates a blank window. The above patch "reuses" that window for the first file that is opened.

Actions such as paste and undo are all "doubled" for that window, as if it is getting two copies of the corresponding signal.

A work-around is to close the unnamed window explicitly before opening a file, or to close the first file opened.

I'm trying to find where the duplicate initialisation is done. In the worst case the patch can be backed out.

Lachlan Andrew <lachlan>
Project MemberIn charge of this item.

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by rik5 (Posted a comment)
  • -unavailable- added by larskindermann (Posted a comment)
  • -unavailable- added by avinoam (Posted a comment)
  • -unavailable- added by lachlan (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 4 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Thu 28 Apr 2016 03:37:18 AM UTCrik5StatusPatch Submitted=>Fixed
      Open/ClosedOpen=>Closed
    Thu 14 Apr 2016 05:33:08 AM UTClachlanAttached File-=>Added bug_47692_double_actions.cset, #36922
      StatusNone=>Patch Submitted

    Back to the top


    Powered by Savane 3.1-cleanup1