bugGNU Octave - Bugs: bug #47672, patch with struct argument does...

 
 

bug #47672: patch with struct argument does not support uppercase letters in fields

Submitted by:  Markus Mützel <mmuetzel>
Submitted on:  Tue 12 Apr 2016 11:06:40 AM UTC  
 
Category: Octave FunctionSeverity: 1 - Wish
Priority: 1 - LaterItem Group: Matlab Compatibility
Status: FixedAssigned to: None
Originator Name: Open/Closed: Closed
Release: devOperating System: Any

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Tue 20 Sep 2016 02:35:08 PM UTC, comment #5:

Pushed the docstring patch here: http://hg.savannah.gnu.org/hgweb/octave/rev/e15b89c4c2dd

Closing as fixed.

Andreas Weber <andy1978>
Project Member
Mon 20 Jun 2016 05:15:42 PM UTC, comment #4:

Attached please find a patch that updates the docstring of patch.m for the changes made in the other changesets.
I also made slight changes to demo #4 to include the syntax with input mixed between property/value pairs and a structure.

(file #37530)

Markus Mützel <mmuetzel>
Project Member
Fri 17 Jun 2016 03:21:51 AM UTC, comment #3:

Let's leave it open until the docstring is fixed, but I've reduced the priority and severity to the minimum.

Lachlan Andrew <lachlan>
Project Member
Fri 03 Jun 2016 01:40:08 PM UTC, comment #2:

This bug was resolved with bug #48038 and changeset 1955af16b42e.

The docstring in patch.m could be adapted to reflect that change. But it is probably not worth leaving this bug open only for this.

Markus Mützel <mmuetzel>
Project Member
Wed 13 Apr 2016 08:08:24 AM UTC, comment #1:

The function "patch" does not correctly handle mixes of structures and prop/value pairs either which work in Matlab.

This patch completely removes the special handling of struct input in "patch". This resolves this issue and the one described in comment #0 for the default branch (needs changeset 38c0c1f5cf57 for mixes of structures and prop/value pairs).

(file #36916)

Markus Mützel <mmuetzel>
Project Member
Tue 12 Apr 2016 11:06:40 AM UTC, original submission:

The function patch supports passing a struct with the fields "faces", "vertices", and optionally "facevertexcdata".
While it is OK for Matlab to mix uppercase and lowercase letters in this fieldnames, Octave only works for lowercase only letters.
A minimal example that works in Matlab but fails in Octave:

I will try and submit a patch for this soon.

Markus Mützel <mmuetzel>
Project Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #37530:  patch_docstring.patch added by mmuetzel (2KiB - text/x-diff)
file #36916:  bug47672.patch added by mmuetzel (2KiB - text/x-diff)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by andy1978 (Posted a comment)
  • -unavailable- added by lachlan (Posted a comment)
  • -unavailable- added by mmuetzel (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 6 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Tue 20 Sep 2016 02:35:08 PM UTCandy1978StatusNone=>Fixed
      Open/ClosedOpen=>Closed
    Mon 20 Jun 2016 05:15:42 PM UTCmmuetzelAttached File-=>Added patch_docstring.patch, #37530
    Fri 17 Jun 2016 03:21:51 AM UTClachlanSeverity3 - Normal=>1 - Wish
      Priority5 - Normal=>1 - Later
    Wed 13 Apr 2016 08:08:24 AM UTCmmuetzelAttached File-=>Added bug47672.patch, #36916

    Back to the top


    Powered by Savane 3.1-cleanup1