bugGNU Octave - Bugs: bug #47621, dbstop LINE_# fails when in debug...

 
 

bug #47621: dbstop LINE_# fails when in debug mode

Submitted by:  Rik <rik5>
Submitted on:  Mon 04 Apr 2016 07:27:43 PM UTC  
 
Category: InterpreterSeverity: 3 - Normal
Priority: 5 - NormalItem Group: Regression
Status: FixedAssigned to: Lachlan Andrew <lachlan>
Originator Name: Open/Closed: Closed
Release: devOperating System: GNU/Linux

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Thu 14 Apr 2016 12:48:59 AM UTC, comment #8:

I pushed the new patch here http://hg.savannah.gnu.org/hgweb/octave/rev/555b6c78d677. Closing report.

Rik <rik5>
Project Administrator
Thu 14 Apr 2016 12:33:00 AM UTC, comment #7:

Thanks, Rik.

On closer inspection, the patch would also have failed for @class/method type functions [the original reason for using the full fcn_file_name() instead of name()], since the '@' wasn't the leading component.

The attached patch should be the "right" solution -- it uses "profiler_name ()" instead of the file name. I've checked that it gets the name right, and that it doesn't introduce multiple entries. It also works @class/method:

gives

(file #36920)

Lachlan Andrew <lachlan>
Project MemberIn charge of this item.
Wed 13 Apr 2016 09:10:59 PM UTC, comment #6:

I just tested the patch and it solves the original problem, but creates a new one. See below

Breakpoints are now listed twice: 1) with the absolute path name, and 2) again with just the shortened form of the function name.

Rik <rik5>
Project Administrator
Tue 12 Apr 2016 06:21:26 PM UTC, comment #5:

On Mageia-5, with the patch, I get this:

so this patch fixes the bug (that I confirmed on a one day older Octave w/o the patch).

Philip Nienhuis <philipnienhuis>
Project Member
Tue 12 Apr 2016 06:02:17 PM UTC, comment #4:

Oh, I've built with the patch before mxe-octave-ing; so I can and will test just after rebooting (and dinner :-) )

Philip Nienhuis <philipnienhuis>
Project Member
Mon 11 Apr 2016 09:09:10 PM UTC, comment #3:

Yes, this is on Linux. I just tested today and the problem is still there. I can't test Lachlan's patch until this weekend.

Rik <rik5>
Project Administrator
Mon 11 Apr 2016 06:54:32 PM UTC, comment #2:

Did this bug occur only on Linux?

I tried this patch on Win 7 (with a recent dev version): the issue illustrated in the example supplied by Rik doesn't occur.
However, earlier octave-4.1.0+ versions I still have installed on Windows (oldest Oct 7 2015) don't show this bug either.

Philip Nienhuis <philipnienhuis>
Project Member
Thu 07 Apr 2016 07:10:36 AM UTC, comment #1:

The same problem would have occurred with relative path names.

It was probably introduced when support for @class/method was introduced. The attached patch strips directory components, unless the first one starts with '@'.

It works on the ls example, and the BIST for @class type identifiers.

(file #36849)

Lachlan Andrew <lachlan>
Project MemberIn charge of this item.
Mon 04 Apr 2016 07:27:43 PM UTC, original submission:

The following code fails in the development version of Octave.

It looks like the add_breakpoint routine might not be able to handle an absolute path name.

Rik <rik5>
Project Administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #36849:  bug_47621_dbstop_implicit_file.cset added by lachlan (916B - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by lachlan (Updated the item)
  • -unavailable- added by rik5 (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 6 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Thu 14 Apr 2016 12:48:59 AM UTCrik5StatusPatch Submitted=>Fixed
      Open/ClosedOpen=>Closed
    Thu 14 Apr 2016 12:33:00 AM UTClachlanAttached File-=>Added bug_47621_dbstop_implicit_file_v2.cset, #36920
    Thu 07 Apr 2016 07:10:36 AM UTClachlanAttached File-=>Added bug_47621_dbstop_implicit_file.cset, #36849
      StatusNone=>Patch Submitted
      Assigned toNone=>lachlan

    Back to the top


    Powered by Savane 3.1-cleanup1