bugGNU Octave - Bugs: bug #47579, mxe-octave: oct files should also...

 
 

bug #47579: mxe-octave: oct files should also be stripped by default

Submitted by:  Mike Miller <mtmiller>
Submitted on:  Wed 30 Mar 2016 11:34:06 PM UTC  
 
Category: Configuration and Build SystemSeverity: 3 - Normal
Priority: 5 - NormalItem Group: Feature Request
Status: FixedAssigned to: None
Originator Name: Open/Closed: Closed
Release: otherOperating System: Microsoft Windows

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Thu 31 Mar 2016 04:37:28 PM UTC, comment #3:

Thanks, closed.

Mike Miller <mtmiller>
Project Administrator
Thu 31 Mar 2016 04:34:22 PM UTC, comment #2:

Works for me - some of the octfiles I checked were over 1M before strip and less than 50K when stripped.

I pushed the changeset up to mxe-octave.

http://hg.octave.org/mxe-octave/rev/0db86306c404

John Donoghue <lostbard>
Project Member
Wed 30 Mar 2016 11:45:46 PM UTC, comment #1:

I'll check it tommorrow, unless someone else gets to it first

John Donoghue <lostbard>
Project Member
Wed 30 Mar 2016 11:34:06 PM UTC, original submission:

The mxe-octave builder strips .dll and .exe by default, it should also strip all *.oct by default.

The attached patch works for me. I have not actually tested running the resulting binary on Windows, though. I would appreciate someone testing to make sure this doesn't break something.

Mike Miller <mtmiller>
Project Administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #36802:  mxe-strip-oct.diff added by mtmiller (822B - text/x-diff)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by lostbard (Posted a comment)
  • -unavailable- added by mtmiller (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 3 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Thu 31 Mar 2016 04:37:28 PM UTCmtmillerStatusPatch Submitted=>Fixed
      Open/ClosedOpen=>Closed
    Wed 30 Mar 2016 11:34:06 PM UTCmtmillerAttached File-=>Added mxe-strip-oct.diff, #36802

    Back to the top


    Powered by Savane 3.1-cleanup1