bugGNU Octave - Bugs: bug #47517, seekg() does not work

 
 

bug #47517: seekg() does not work

Submitted by:  Lachlan Andrew <lachlan>
Submitted on:  Thu 24 Mar 2016 03:06:19 AM UTC  
 
Category: Octave FunctionSeverity: 3 - Normal
Priority: 5 - NormalItem Group: Matlab Compatibility
Status: FixedAssigned to: Lachlan Andrew <lachlan>
Originator Name: LachlanOpen/Closed: Closed
Release: devOperating System: Any

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Mon 28 Mar 2016 05:22:27 PM UTC, comment #3:

I've applied the patch with some minor tweaks to the commit message. I also used gnulib::fseeko and gnulib::ftello.

http://hg.savannah.gnu.org/hgweb/octave/rev/7ebd8ac26178

Mike Miller <mtmiller>
Project Administrator
Fri 25 Mar 2016 11:40:21 PM UTC, comment #2:

I meant to ask if you can rebase the patch against the current version of textscan in {file-io,oct-stream}.{cc,h} so it can be applied to the current default branch.

Mike Miller <mtmiller>
Project Administrator
Fri 25 Mar 2016 11:38:44 PM UTC, comment #1:

Can you reattach the changeset here?

Patch #8783 has such a long history it's unfortunately hard to see which changes are revisions of earlier ones and which are additional independent changes.

Let's consider that patch tracker item done, and anything still left undone in should be reposted as new patches or bugs against the new textscan.

And can I assume this is related to bug #47537 that I just filed?

Mike Miller <mtmiller>
Project Administrator
Thu 24 Mar 2016 03:06:19 AM UTC, original submission:

The function seek_off() and seek_pos () are commented out in c-file-ptr-stream.cc. This means that seekg() doesn't work.

When textscan is called for a second time on a file, it needs to seek to the correct position.

This feature is enabled by file #36334 at patch #8783, but that changeset seems not to have been applied.

Could someone please review it?

Lachlan Andrew <lachlan>
Project MemberIn charge of this item.

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by mtmiller (Posted a comment)
  • -unavailable- added by lachlan (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 2 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Mon 28 Mar 2016 05:22:27 PM UTCmtmillerStatusPatch Submitted=>Fixed
      Open/ClosedOpen=>Closed

    Back to the top


    Powered by Savane 3.1-cleanup1