bugGNU Octave - Bugs: bug #47503, geometry package: remove use of...

 
 

bug #47503: geometry package: remove use of deprecated octave_config_info

Submitted by:  CarnĂ« Draug <carandraug>
Submitted on:  Wed 23 Mar 2016 02:27:06 AM UTC  
 
Category: Octave Forge PackageSeverity: 3 - Normal
Priority: 5 - NormalItem Group: None
Status: FixedAssigned to: None
Originator Name: Open/Closed: Closed
Release: otherOperating System: Any

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Thu 24 Mar 2016 12:02:40 PM UTC, comment #1:

Thank you very much. Nice improvement!
I have updated the package. Please close this bug.

Juan Pablo Carbajal <juanpi>
Project Member
Wed 23 Mar 2016 02:27:06 AM UTC, original submission:

The PKG_ADD and PKG_DEL packages in the geometry package access details form octave_config_info in case they are installed in the arch dependent directory. However, this package no longer has oct files so it's no longer necessary.

Even, if there were oct files in the geometry package, a better solution is a private function with PKG_ADD directives to call itself. The attached patch also does it.

In addition, it seems to me that the PKG_ADD (and PKG_DEL) files have an extra code for the case of being used in testing (instead of properly installed via pkg). However, the recommended way to test the package should be via its Makefile "make run". I have also modified the Makefile to check for the presence of PKG_ADD directives.

Finally, I have further reduce the code by keeping the whole logic in a single place and only changing the addpath/rmpath based on a binary call to the binary package.

This solution should make the geometry easier to maintain (and also no longer dependent on the deprecated octave_config_info).

Carnë Draug <carandraug>
Project Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #36731:  replace_PKG_files.cset added by carandraug (7KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by juanpi (Posted a comment)
  • -unavailable- added by carandraug (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 3 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Thu 24 Mar 2016 01:06:40 PM UTCcarandraugStatusNone=>Fixed
      Open/ClosedOpen=>Closed
    Wed 23 Mar 2016 02:27:06 AM UTCcarandraugAttached File-=>Added replace_PKG_files.cset, #36731

    Back to the top


    Powered by Savane 3.1-cleanup1