bugGNU Octave - Bugs: bug #47503, geometry package: remove use of...

 
 

bug #47503: geometry package: remove use of deprecated octave_config_info

Submitter:  CarnĂ« Draug <carandraug>
Submitted:  Wed 23 Mar 2016 02:27:06 AM UTC
   
 
Category:  Octave Package Severity:  3 - Normal
Priority:  5 - Normal Item Group:  None
Status:  Fixed Assigned to:  None
Originator Name:  Open/Closed:  * Closed
Release:  * other Operating System:  * Any
Fixed Release:  None Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Thu 24 Mar 2016 12:02:40 PM UTC, comment #1: 

Thank you very much. Nice improvement!
I have updated the package. Please close this bug.

Juan Pablo Carbajal <juanpi>
Group Member
Wed 23 Mar 2016 02:27:06 AM UTC, original submission:  

The PKG_ADD and PKG_DEL packages in the geometry package access details form octave_config_info in case they are installed in the arch dependent directory.  However, this package no longer has oct files so it's no longer necessary.

Even, if there were oct files in the geometry package, a better solution is a private function with PKG_ADD directives to call itself.  The attached patch also does it.

In addition, it seems to me that the PKG_ADD (and PKG_DEL) files have an extra code for the case of being used in testing (instead of properly installed via pkg).  However, the recommended way to test the package should be via its Makefile "make run".  I have also modified the Makefile to check for the presence of PKG_ADD directives.

Finally, I have further reduce the code by keeping the whole logic in a single place and only changing the addpath/rmpath based on a binary call to the binary package.

This solution should make the geometry easier to maintain (and also no longer dependent on the deprecated octave_config_info).

Carnë Draug <carandraug>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #36731:  replace_PKG_files.cset added by carandraug (7KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by juanpi (Posted a comment)
  • -email is unavailable- added by carandraug (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2016-03-24 carandraug StatusNone Fixed
        Open/ClosedOpen Closed
    2016-03-23 carandraug Attached File- Added replace_PKG_files.cset, #36731

    Back to the top

    Powered by Savane 3.13-02a9.
    Corresponding source code