bugGNU Octave - Bugs: bug #47494, mxe-octave: OF mapping package...

 
 

bug #47494: mxe-octave: OF mapping package shadows rad2deg & deg2rad in dev octave

Submitted by:  Philip Nienhuis <philipnienhuis>
Submitted on:  Tue 22 Mar 2016 07:49:14 AM UTC  
 
Category:  Configuration and Build System Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Incorrect Result
Status:  Fixed Assigned to:  John Donoghue <lostbard>
Originator Name:  Philip Nienhuis Open/Closed:  Closed
Release:  other Operating System:  Microsoft Windows

Add a New Comment (Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

( Jump to the original submission)

Sun 03 Sep 2017 06:13:36 PM UTC, comment #17: 

That's what I red in a second pass yes :-)
OK report is closed so let's finish the discussion too

Philip Nienhuis <philipnienhuis>
Project Member
Sun 03 Sep 2017 06:05:02 PM UTC, comment #16: 

sorry - does not show the shadows core functions message, and ok tests in the package pass :)

John Donoghue <lostbard>
Project MemberIn charge of this item.
Sun 03 Sep 2017 05:00:31 PM UTC, comment #15: 

Oh hang on ... "doesn't complain" (I read "doesn't compile")

Philip Nienhuis <philipnienhuis>
Project Member
Sun 03 Sep 2017 04:59:31 PM UTC, comment #14: 

In an mxe-octave build on mine yesterday it built fine and works fine.
Another reason to weed stuff out as per comment #10 then.

Unfortunately for the OF mapping package I may have time only after several weeks. Priority for me now is to fix OF io.

Philip Nienhuis <philipnienhuis>
Project Member
Sun 03 Sep 2017 02:32:57 PM UTC, comment #13: 

It doesn't complain for me any more when built with dev, and passes all tests

John Donoghue <lostbard>
Project MemberIn charge of this item.
Sun 03 Sep 2017 01:18:36 PM UTC, comment #12: 

I make mxe-octave cross-builds with a weeded out (development) mapping package as per my comment #10 since early this year, so I can't check this easily.

Hopefully someone else will test.

Philip Nienhuis <philipnienhuis>
Project Member
Sun 03 Sep 2017 01:31:36 AM UTC, comment #11: 

This was marked Ready for Test on August 15th.  Can it be closed now?

Rik <rik5>
Project Administrator
Fri 18 Aug 2017 10:25:59 PM UTC, comment #10: 

Another fix I'm inclined to apply is to simply drop deg2rad and rad2deg completely from the mapping package. JuanPi did the same for the geometry package.
After all, Octave-4.0+ is outdated now and in mxe-octave, stable-octave is 4.2.+

In that case also the autotools / bootstrap / configure stuff in of-mapping that is needed for merely those 2 files can be dropped. If I (as mapping pkg maintainer) go that route, some changes are needed for the module(s) depending on gdal. For the latter Carnë also implemented a neat trick to gracefully inform users if the gdal dependency is missing. But (again like JuanPi) I'd rather let users be confronted with the error messages related to the missing dependency.

Philip Nienhuis <philipnienhuis>
Project Member
Tue 15 Aug 2017 12:06:02 PM UTC, comment #9: 
John Donoghue <lostbard>
Project MemberIn charge of this item.
Tue 15 Aug 2017 12:45:37 AM UTC, comment #8: 

I'll verify it works, and close unless someone else beats me to it

John Donoghue <lostbard>
Project MemberIn charge of this item.
Tue 15 Aug 2017 12:22:17 AM UTC, comment #7: 

Sorry, I mean someone can remove the patch and mark this as fixed, with the patch in place it is still forcing the wrong behavior.

Mike Miller <mtmiller>
Project Administrator
Tue 15 Aug 2017 12:21:39 AM UTC, comment #6: 

Ok, so this is no longer an issue in the 4.2 release anyway? If that's the case, I agree, closing as fixed.

Mike Miller <mtmiller>
Project Administrator
Mon 14 Aug 2017 09:22:57 PM UTC, comment #5: 

It seems OK to me to remove the patch if things work properly without it.

John W. Eaton <jwe>
Project Administrator
Mon 14 Aug 2017 09:01:34 PM UTC, comment #4: 

Since the this bug was created, octave is checked for in requirements for mxe, and then warns is a non matching octave is found with a comment about it potentially causing packages not to install.

So, can we just remove the patch all together and rely on mxe builders ensuring they have the correct octave installed?

John Donoghue <lostbard>
Project MemberIn charge of this item.
Mon 14 Aug 2017 05:16:06 PM UTC, comment #3: 

The simplest answer to this bug is to reverse the sense of the patch now that mxe-octave supports Octave 4.2.

Can someone test the attached patch to mxe-octave please? With either Octave 4.2 or dev, the answer should be the same in both.

(file #41519)

Mike Miller <mtmiller>
Project Administrator
Sun 27 Mar 2016 04:13:58 PM UTC, comment #2: 

AFAIK "eval" is used to find out if rad2deg/deg2rad are in core or not.
Carnë devised the configure trick in <of-mapping>/src/confgure.ac to get this together. It's a neat one I think but as it turns out it's also fragile.

But -again AFAIK- whether rad2deg/deg2rad are in core is completely version-dependent. In 4.0+ they are in core, before that version they aren't.
Octave's version is known in mxe-octave, so some workaround should be possible. However I lack the skills for that :-(

Philip Nienhuis <philipnienhuis>
Project Member
Sat 26 Mar 2016 12:14:10 AM UTC, comment #1: 

note, in mxe octave, there is currently a patch to the makefile to include rad2reg etc as when cross compiling, as it couldnt do the octave eval call in make.

John Donoghue <lostbard>
Project MemberIn charge of this item.
Tue 22 Mar 2016 07:49:14 AM UTC, original submission:  

The OF mapping package, installed in the development version of Octave built with MXE for Windows, complains about shadowing core functions rad2deg and deg2rad.

The cause appears to be that an ingenuous setup by Carnë to only supply these functions for stable octave has been mangled a bit by the setup to build the mapping package in mxe-octave.

Philip Nienhuis <philipnienhuis>
Project Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #41519:  of-mapping.patch added by mtmiller (2KiB - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by rik5 (Posted a comment)
  • -email is unavailable- added by jwe (Posted a comment)
  • -email is unavailable- added by mtmiller (Updated the item)
  • -email is unavailable- added by lostbard (Posted a comment)
  • -email is unavailable- added by philipnienhuis (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

     

     

    Follow 13 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2017-09-03 lostbard StatusReady For Test => Fixed
        Open/ClosedOpen => Closed
    2017-08-15 lostbard StatusIn Progress => Ready For Test
    2017-08-15 lostbard Assigned toNone => lostbard
    2017-08-15 mtmiller StatusFixed => In Progress
        Open/ClosedClosed => Open
    2017-08-15 mtmiller StatusPatch Submitted => Fixed
        Open/ClosedOpen => Closed
    2017-08-14 mtmiller StatusNone => Patch Submitted
    2017-08-14 mtmiller Attached File- => Added of-mapping.patch, #41519
    2016-04-29 mtmiller Summary[MXE] OF mapping package shadows rad2deg & deg2rad in dev octave => mxe-octave: OF mapping package shadows rad2deg & deg2rad in dev octave
    2016-03-22 rik5 Carbon-CopyRemoved 72865 => -
    2016-03-22 rik5 Summary[MXE] OF mapping package shadows rad2deg & deg3rad in dev octave => [MXE] OF mapping package shadows rad2deg & deg2rad in dev octave

    Back to the top


    Powered by Savane 3.5