Sun 03 Sep 2017 06:13:36 PM UTC, comment #17:
That's what I red in a second pass yes :-)
OK report is closed so let's finish the discussion too
|
Sun 03 Sep 2017 06:05:02 PM UTC, comment #16:
sorry - does not show the shadows core functions message, and ok tests in the package pass :)
|
Sun 03 Sep 2017 05:00:31 PM UTC, comment #15:
Oh hang on ... "doesn't complain" (I read "doesn't compile")
|
Sun 03 Sep 2017 04:59:31 PM UTC, comment #14:
In an mxe-octave build on mine yesterday it built fine and works fine.
Another reason to weed stuff out as per comment #10 then.
Unfortunately for the OF mapping package I may have time only after several weeks. Priority for me now is to fix OF io.
|
Sun 03 Sep 2017 02:32:57 PM UTC, comment #13:
It doesn't complain for me any more when built with dev, and passes all tests
|
Sun 03 Sep 2017 01:18:36 PM UTC, comment #12:
I make mxe-octave cross-builds with a weeded out (development) mapping package as per my comment #10 since early this year, so I can't check this easily.
Hopefully someone else will test.
|
Sun 03 Sep 2017 01:31:36 AM UTC, comment #11:
This was marked Ready for Test on August 15th. Can it be closed now?
|
Fri 18 Aug 2017 10:25:59 PM UTC, comment #10:
Another fix I'm inclined to apply is to simply drop deg2rad and rad2deg completely from the mapping package. JuanPi did the same for the geometry package.
After all, Octave-4.0+ is outdated now and in mxe-octave, stable-octave is 4.2.+
In that case also the autotools / bootstrap / configure stuff in of-mapping that is needed for merely those 2 files can be dropped. If I (as mapping pkg maintainer) go that route, some changes are needed for the module(s) depending on gdal. For the latter Carnë also implemented a neat trick to gracefully inform users if the gdal dependency is missing. But (again like JuanPi) I'd rather let users be confronted with the error messages related to the missing dependency.
|
Tue 15 Aug 2017 12:06:02 PM UTC, comment #9:
Pushed http://hg.octave.org/mxe-octave/rev/f81858aaddc8
|
Tue 15 Aug 2017 12:45:37 AM UTC, comment #8:
I'll verify it works, and close unless someone else beats me to it
|
Tue 15 Aug 2017 12:22:17 AM UTC, comment #7:
Sorry, I mean someone can remove the patch and mark this as fixed, with the patch in place it is still forcing the wrong behavior.
|
Tue 15 Aug 2017 12:21:39 AM UTC, comment #6:
Ok, so this is no longer an issue in the 4.2 release anyway? If that's the case, I agree, closing as fixed.
|
Mon 14 Aug 2017 09:22:57 PM UTC, comment #5:
It seems OK to me to remove the patch if things work properly without it.
|
Mon 14 Aug 2017 09:01:34 PM UTC, comment #4:
Since the this bug was created, octave is checked for in requirements for mxe, and then warns is a non matching octave is found with a comment about it potentially causing packages not to install.
So, can we just remove the patch all together and rely on mxe builders ensuring they have the correct octave installed?
|
Mon 14 Aug 2017 05:16:06 PM UTC, comment #3:
The simplest answer to this bug is to reverse the sense of the patch now that mxe-octave supports Octave 4.2.
Can someone test the attached patch to mxe-octave please? With either Octave 4.2 or dev, the answer should be the same in both.
(file #41519)
|
Sun 27 Mar 2016 04:13:58 PM UTC, comment #2:
AFAIK "eval" is used to find out if rad2deg/deg2rad are in core or not.
Carnë devised the configure trick in <of-mapping>/src/confgure.ac to get this together. It's a neat one I think but as it turns out it's also fragile.
But -again AFAIK- whether rad2deg/deg2rad are in core is completely version-dependent. In 4.0+ they are in core, before that version they aren't.
Octave's version is known in mxe-octave, so some workaround should be possible. However I lack the skills for that :-(
|
Sat 26 Mar 2016 12:14:10 AM UTC, comment #1:
note, in mxe octave, there is currently a patch to the makefile to include rad2reg etc as when cross compiling, as it couldnt do the octave eval call in make.
|
Tue 22 Mar 2016 07:49:14 AM UTC, original submission:
The OF mapping package, installed in the development version of Octave built with MXE for Windows, complains about shadowing core functions rad2deg and deg2rad.
The cause appears to be that an ingenuous setup by Carnë to only supply these functions for stable octave has been mangled a bit by the setup to build the mapping package in mxe-octave.
|