bugGNU Octave - Bugs: bug #47371, GUI operations require readline,...

 
 

bug #47371: GUI operations require readline, error or ignore --no-line-editing when starting GUI

Submitted by:  Mike Miller <mtmiller>
Submitted on:  Wed 09 Mar 2016 06:06:24 PM UTC  
 
Category: GUISeverity: 2 - Minor
Priority: 3 - LowItem Group: Other
Status: FixedAssigned to: None
Originator Name: Open/Closed: Closed
Release: devOperating System: Any

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Thu 10 Mar 2016 12:14:57 AM UTC, comment #5:

Not completely simple, I tried a couple different approaches but settled on this as the easiest/clearest and analogous to other checks like not having a DISPLAY:

http://hg.savannah.gnu.org/hgweb/octave/rev/d6c6cf748fc9

Mike Miller <mtmiller>
Project Administrator
Wed 09 Mar 2016 08:31:18 PM UTC, comment #4:

It seems simplest to error out immediately because the check can be made in a single location during the input processing.

Rik <rik5>
Project Administrator
Wed 09 Mar 2016 07:59:35 PM UTC, comment #3:

Sorry, to clarify this is about the Octave command-line switch --no-line-editing. Even if Octave is built with readline, you can run it with --no-line-editing. Try it.

But doing so makes large parts of the GUI non-functional (things where clicking on a button in the GUI affects the interpreter state). So I think this should be prevented somehow, by either forcibly enabling readline anyway or by erroring out to the terminal that the GUI can't be started with --no-line-editing.

Mike Miller <mtmiller>
Project Administrator
Wed 09 Mar 2016 07:56:30 PM UTC, comment #2:

I never think it is a good idea to second guess the programmer. If they are trying to configure a system with a GUI, but no readline, then we shouldn't ignore their wishes and compile readline in to the executable. Of course, since this is a pretty hopeless scenario we should emit an error and stop configure.

Rik <rik5>
Project Administrator
Wed 09 Mar 2016 07:23:54 PM UTC, comment #1:

Actually, the GUI becomes very useless without --no-line-editing, I think it should not be possible to run that way. Should we report an error or should we use readline anyway if the combination of GUI and --no-line-editing are used?

Mike Miller <mtmiller>
Project Administrator
Wed 09 Mar 2016 06:06:24 PM UTC, original submission:

The GUI is forcing rl_initialize to be called even though --no-line-editing is given. Only found on a system with a buggy readline installation. Setting a breakpoint on rl_initialize confirms that the GUI thread is invoking the command_editor before the interpreter is started, so the --no-line-editing logic is not yet applied.

Mike Miller <mtmiller>
Project Administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by rik5 (Posted a comment)
  • -unavailable- added by mtmiller (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 6 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Thu 10 Mar 2016 12:14:57 AM UTCmtmillerStatusNeed Info=>Fixed
      Open/ClosedOpen=>Closed
    Wed 09 Mar 2016 07:23:54 PM UTCmtmillerPriority5 - Normal=>3 - Low
      StatusNone=>Need Info
      Operating SystemGNU/Linux=>Any
      Summaryreadline is still initialized with --no-line-editing=>GUI operations require readline, error or ignore --no-line-editing when starting GUI

    Back to the top


    Powered by Savane 3.1-cleanup1