bugGNU Octave - Bugs: bug #47288, interval package: wont install on...

 
 

bug #47288: interval package: wont install on 4.1.0+ dev octave

Submitted by:  John Donoghue <lostbard>
Submitted on:  Sat 27 Feb 2016 06:31:29 PM UTC  
 
Category: Octave Forge PackageSeverity: 3 - Normal
Priority: 5 - NormalItem Group: Build Failure
Status: FixedAssigned to: None
Originator Name: lostbardOpen/Closed: Closed
Release: 4.2.0Operating System: Any

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Wed 18 Jan 2017 06:06:10 PM UTC, comment #9:

Done

Avinoam Kalma <avinoam>
Project Member
Wed 18 Jan 2017 06:03:37 PM UTC, comment #8:

Yes, please mark it as fixed.

The original error has been fixed in this revision:
https://sourceforge.net/p/octave/interval/ci/2834d14c761a7c20f2a9ce810317d942aebc0462/

and has been released as part of version 1.5.0, see https://octave.sourceforge.io/interval/NEWS.html

The other error (M_PI / c++11) is a separate issue and probably has already been fixed elsewhere.

Oliver Heimlich <oheim>
Wed 18 Jan 2017 05:14:09 PM UTC, comment #7:

Should I close this report as fixed?

Avinoam Kalma <avinoam>
Project Member
Mon 28 Nov 2016 01:58:50 PM UTC, comment #6:

I think my comment can be ignored now - it appears to work on both the w32 and w64 installer

I may have been playing around with flags for other packages and had set CPPFLAGS=c++11 - which does make it fail with error below.

John Donoghue <lostbard>
Project Member
Mon 28 Nov 2016 01:27:59 PM UTC, comment #5:

I cannot reproduce the installation error in Windows with Octave 4.2.0. Do you use the official installer for Octave?

Oliver Heimlich <oheim>
Thu 24 Nov 2016 03:06:06 PM UTC, comment #4:

Still fails in windows with octave 4.2.0, however now because M_PI is not defined.

(interval 2.0.0)

Similar issue seen in level-set reported in bug #49294

John Donoghue <lostbard>
Project Member
Fri 04 Mar 2016 07:01:26 AM UTC, comment #3:

Thanks, I will use your patch.

Oliver Heimlich <oheim>
Thu 03 Mar 2016 05:04:49 PM UTC, comment #2:

Actually the OpenMP standard specifies that the _OPENMP macro is defined if OpenMP is active. So you should be able to rely on that and do something like the attached instead.

(file #36536)

Mike Miller <mtmiller>
Project Administrator
Wed 02 Mar 2016 11:30:12 PM UTC, comment #1:

Could a C++ expert please review the attached patch?

I have removed the #include directive on oct-openmp.h in the interval package and use plain #pragma directives. My understanding is that these directives will be ignored if OpenMP is not present or not enabled.

Additionally, I have added a -Wno-unknown-pragmas switch to the compiler. The absence of OpenMP pragmas should be no problem since it will simply disable parallel execution.

(file #36531)

Oliver Heimlich <oheim>
Sat 27 Feb 2016 06:31:29 PM UTC, original submission:

WIth recent changes to dev octave (removed oct-openmp.h), interval will no longer compile:

John Donoghue <lostbard>
Project Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #36536:  bug-47288-2.diff added by mtmiller (3KiB - text/x-diff)
file #36531:  bug-47288.diff added by oheim (3KiB - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by avinoam (Posted a comment)
  • -unavailable- added by mtmiller (Updated the item)
  • -unavailable- added by oheim (Updated the item)
  • -unavailable- added by lostbard (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 6 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 18 Jan 2017 06:06:10 PM UTCavinoamStatusPatch Submitted=>Fixed
      Open/ClosedOpen=>Closed
    Thu 24 Nov 2016 03:06:06 PM UTClostbardReleasedev=>4.2.0
    Thu 03 Mar 2016 05:04:49 PM UTCmtmillerAttached File-=>Added bug-47288-2.diff, #36536
      StatusNone=>Patch Submitted
    Wed 02 Mar 2016 11:30:12 PM UTCoheimAttached File-=>Added bug-47288.diff, #36531

    Back to the top


    Powered by Savane 3.1-cleanup1