bugGNU Octave - Bugs: bug #47277, QA target...

 
 

bug #47277: QA target "check-missing-semicolon" fails on some m-files

Submitted by:  Mike Miller <mtmiller>
Submitted on:  Fri 26 Feb 2016 07:42:58 PM UTC  
 
Category: Configuration and Build SystemSeverity: 1 - Wish
Priority: 5 - NormalItem Group: Other
Status: FixedAssigned to: None
Originator Name: Open/Closed: Closed
Release: devOperating System: Any

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Tue 01 Mar 2016 07:52:12 PM UTC, comment #2:

The issue turns out to be that Octave can not source m-files that contain a classdef declaration or a nested function; Subfunctions are acceptable. I cleaned up the Mike's hack a bit and then cleaned up the files reported to be missing a semicolon (http://hg.savannah.gnu.org/hgweb/octave/rev/89fa0694aa2e).

I think this is good enough for now. Closing report.

Rik <rik5>
Project Administrator
Sat 27 Feb 2016 02:42:25 AM UTC, comment #1:

On a slightly related issue, Matlab's GUI has all sorts of warnings can come from parsing the file being edited. One of them is missing semicolons.

If someone writes a reliable way to check for semicolons, it would be great to integrate it with the GUI editor.

Lachlan Andrew <lachlan>
Project Member
Fri 26 Feb 2016 07:42:58 PM UTC, original submission:

Extremely minor issue. I ran across this target I didn't even know existed, "make check-missing-semicolon" loads all m-files in the Octave distribution and reports on lines that do not end with a semicolon.

Target had been broken since the Makefile reorg a few months ago, that is not fixed. It now breaks because certain types of m-files cannot be sourced, in particular m-files that define classdef classes or m-files that have subfunctions (at least those are the errors I saw when trying to run the target).

The attached quick-n-dirty hack fixed the target for me by skipping over the files in question, but prevents a few files from being checked. Maybe someone would want to work on a different way to parse and check for such things?

Mike Miller <mtmiller>
Project Administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by rik5 (Posted a comment)
  • -unavailable- added by lachlan (Posted a comment)
  • -unavailable- added by mtmiller (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 3 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Tue 01 Mar 2016 07:52:12 PM UTCrik5StatusNone=>Fixed
      Open/ClosedOpen=>Closed
    Fri 26 Feb 2016 07:42:58 PM UTCmtmillerAttached File-=>Added check-missing-semicolon.diff, #36477

    Back to the top


    Powered by Savane 3.1-cleanup1