bugGNU Octave - Bugs: bug #47226, GUI build failure with QScintilla...

 
 

bug #47226: GUI build failure with QScintilla 2.4

Submitted by:  Mike Miller <mtmiller>
Submitted on:  Mon 22 Feb 2016 08:15:16 PM UTC  
 
Category: GUISeverity: 3 - Normal
Priority: 5 - NormalItem Group: Build Failure
Status: FixedAssigned to: Lachlan Andrew <lachlan>
Originator Name: Open/Closed: Closed
Release: devOperating System: Any

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Mon 29 Feb 2016 01:52:30 AM UTC, comment #3:

@Lachlan: I applied your patch here (http://hg.savannah.gnu.org/hgweb/octave/rev/dc3252099232). Closing report.

Rik <rik5>
Project Administrator
Wed 24 Feb 2016 09:20:36 AM UTC, comment #2:

This patch should fix the problem, though I can't check since I don't have QScintilla 2.4.

Simply making the functions no-ops would leave a context menu that did nothing, so I've disabled the context menu in the left margin.

In the longer term, I'd like to install QScintilla 2.4 in a VM and see if the functionality can be provided without 2.6.

(file #36449)

Lachlan Andrew <lachlan>
Project MemberIn charge of this item.
Wed 24 Feb 2016 07:00:12 AM UTC, comment #1:

Thanks. I'll look into it.

Lachlan Andrew <lachlan>
Project MemberIn charge of this item.
Mon 22 Feb 2016 08:15:16 PM UTC, original submission:

The changeset added recently for improved debugging condtionally defines some member functions in the octave_qscintilla class

http://hg.savannah.gnu.org/hgweb/octave/rev/65827e9cccb8

The contextmenu_break_condition() and contextmenu_break_once() functions are declared in the class, but only defined if Qscintilla is 2.6 or higher. The member functions need to exist unconditionally, and either noop or throw an error or whatever is appropriate if the necessary Qscintilla features are not available.

Mike Miller <mtmiller>
Project Administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #36449:  bug_47226.cset added by lachlan (3KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by rik5 (Posted a comment)
  • -unavailable- added by lachlan (Posted a comment)
  • -unavailable- added by mtmiller (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 6 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Mon 29 Feb 2016 01:52:30 AM UTCrik5StatusPatch Submitted=>Fixed
      Open/ClosedOpen=>Closed
    Wed 24 Feb 2016 09:20:36 AM UTClachlanAttached File-=>Added bug_47226.cset, #36449
      StatusIn Progress=>Patch Submitted
      Assigned toNone=>lachlan
    Wed 24 Feb 2016 07:00:12 AM UTClachlanStatusNone=>In Progress

    Back to the top


    Powered by Savane 3.1-cleanup1