bugGNU Octave - Bugs: bug #47013, bug in spline function

 
 

bug #47013: bug in spline function

Submitted by:  None
Submitted on:  Fri 29 Jan 2016 05:04:39 PM UTC  
 
Category: Octave FunctionSeverity: 3 - Normal
Priority: 5 - NormalItem Group: Incorrect Result
Status: FixedAssigned to: None
Originator Name: bug in spline functionOriginator Email: -unavailable-
Open/Closed: ClosedRelease: 4.0.0
Operating System: GNU/Linux

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sat 20 Feb 2016 08:11:01 PM UTC, comment #5:

I applied Lachlan's patch to stable (http://hg.savannah.gnu.org/hgweb/octave/rev/7a91166b1d09). This should be a part of the 4.0.1 bug fix release.

Rik <rik5>
Project Administrator
Tue 16 Feb 2016 12:05:42 PM UTC, comment #4:

I can confirm that the other cases do not also need the added .'(:). The attached patch makes that clearer by removing some unnecessary code, which took (1:n-1,:) of vectors that were already row vectors.

The change in 138~139 seems unnecessary because of automatic broadcasting.

(file #36356)

Lachlan Andrew <lachlan>
Project Member
Mon 15 Feb 2016 10:05:36 PM UTC, comment #3:

Confirming that Marco's change fixes the reported problem and attaching as a diff (just to make clear which lines were changed). I can't say whether this change is appropriate or complete.

(file #36350)

Mike Miller <mtmiller>
Project Administrator
Mon 01 Feb 2016 08:44:02 AM UTC, comment #2:

I confirm the problem and I was able to fix with the only change

Can you confirm?

Marco Caliari <caliari>
Project Member
Fri 29 Jan 2016 05:09:28 PM UTC, comment #1:

Note:

I was trying to implement the example of MatLab function spline:

It returned an error, and I tried to fix it.

This is my fixed source code.

ChingChuan Chen

Anonymous
Fri 29 Jan 2016 05:04:39 PM UTC, original submission:

Hi,

There is a bug in spline.

For the complete case in function `spline`, when n > 2,

(line 138 ~ 139 in source code)

should be

and (line 147~150 in source code)

should be

sincerely,

ChingChuan Chen

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #36356:  bug_47013.cset added by lachlan (2KiB - application/octet-stream)
file #36350:  spline.diff added by mtmiller (549B - text/x-diff)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by rik5 (Posted a comment)
  • -unavailable- added by lachlan (Updated the item)
  • -unavailable- added by mtmiller (Updated the item)
  • -unavailable- added by caliari (Posted a comment)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 7 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sat 20 Feb 2016 08:11:01 PM UTCrik5StatusPatch Submitted=>Fixed
      Open/ClosedOpen=>Closed
    Tue 16 Feb 2016 12:05:42 PM UTClachlanAttached File-=>Added bug_47013.cset, #36356
    Mon 15 Feb 2016 10:05:36 PM UTCmtmillerAttached File-=>Added spline.diff, #36350
      CategoryNone=>Octave Function
      StatusConfirmed=>Patch Submitted
    Mon 01 Feb 2016 08:44:02 AM UTCcaliariStatusNone=>Confirmed

    Back to the top


    Powered by Savane 3.1-cleanup1