bugGNU Octave - Bugs: bug #46856, Add 'stable' flag for `unique` and...

 
 

bug #46856: Add 'stable' flag for `unique` and related fiunctions?

Submitted by:  Luis Mendo <lmendo>
Submitted on:  Fri 08 Jan 2016 11:56:17 PM UTC  
 
Category: Octave FunctionSeverity: 3 - Normal
Priority: 5 - NormalItem Group: Feature Request
Status: ConfirmedAssigned to: None
Originator Name: Luis MendoOpen/Closed: Open
Release: 4.0.0Operating System: Any

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Sat 26 Nov 2016 12:08:28 AM UTC, comment #12:

See also bug #38460

kire pudsje <kpc>
Fri 11 Mar 2016 09:00:40 PM UTC, comment #11:

I've modified the set functions so that now they produce row ouput if first two inputs are rows

Luis Mendo <lmendo>
Thu 11 Feb 2016 01:20:10 PM UTC, comment #10:

Thanks, Luis. These look like great progress.

Some quick comments about formatting:
- Octave's style is to use "endif", "endfunction" etc. instead of just "end".
- Octave's style is not to have multiple statements on one line. Every ";", "if", "end..." etc should be on its own line.
- Indentation is by two spaces, not four.
- The bracket of a function call has a space before it.
- "!" is used for not instead of "~".
- The entire body of the function is indented.
- The conditions of "if", "while" etc. have brackets around them.

Many of the guidelines are state at

When I first started submitting patches, I found the emphasis on formatting frustrating, but I can now see how much easier it is to read code when it is uniform.

I don't think you need to use varargin. You can just specify the names of the variables (A, B, str1, str2), and if it is called with fewer variables, then the later ones just have an undefined value. That will make the code easier to read.

The code seems to provide all of the outputs provided "stable" isn't specified, so no functionality is lost. That is good.

Leaving the C++ to do the hard work is also sensible; we can just rename the built-in so that we don't have these wrappers sharing the same names.

Matlab has introduced 'legacy', in addition to 'stable'. The main difference seems to be in the second output, so it doesn't affect us yet, but we may want to handle that before the patches get applied.

Thanks for your contribution.

Lachlan Andrew <lachlan>
Project Member
Wed 10 Feb 2016 08:50:49 PM UTC, comment #9:

Sorry for the delay. I have attached my modified functions for `union`, `intersect`, `setdiff`, `setxor`. They add support for the `'stable'` input flag, but with the following limitations:

- They only work in the single-output case
- They are not a replacement for the builtin functions. Rather, they intercept them, do the necessary changes, and call the builtin functions to do most of the work

(file #36302, file #36303, file #36304, file #36305)

Luis Mendo <lmendo>
Thu 21 Jan 2016 11:04:07 PM UTC, comment #8:

Thanks, Lachlan (also for your other message). It's all clearer to me now.

I'll post my functions hopefully next week. I'm busy now but I do want to contribute!

Luis Mendo <lmendo>
Mon 18 Jan 2016 01:17:29 AM UTC, comment #7:

Luis, yes please post your patches or new versions.

Answering your questions:

Yes, Octave does update its behaviour to follow Matlab, if the new behaviour is considered worthwhile. If users contribute patches, that speeds up the inclusion of the new behaviour.

I don't know if my modified version will be included or not -- I'm just a user like you, not a registered developer. They're busy getting 4.2 ready now, and it may have to wait until 4.4, but it will probably get there eventually.

If you post your changes here, I'll take a pass to remove issues that I know Rik would comment on (like the coding standards, as far as I understand them) to reduce his workload, and make the inclusion more likely.

Lachlan Andrew <lachlan>
Project Member
Fri 15 Jan 2016 07:29:17 PM UTC, comment #6:

Thanks! This seems to work fine.

As for the other functions, I did modify them already to include 'stable' behaviour, although I didn't extensively test. I can submit them if they may be useful for other people.

Speaking of that, I'm new to Octave so I don't know how this works. Will your modified version be included in a next release of Octave? Would mine as well (after adqeuate testing)? When Matlab changes some function's behaviour, does Octave follow (with a reasonable delay), or does it stick to the old behaviour? What's the role of user contribution regarding this?

Sorry for this many questions! I just want to know how this works, and if my modified functions may help I'll be happy to submit them.

Luis Mendo <lmendo>
Fri 15 Jan 2016 07:00:56 AM UTC, comment #5:

Thanks, Luis. The new version fixes that, but may have messed up something else. Could you give it a try?

Do you want to modify the other functions, or do you want me to?

(file #36043)

Lachlan Andrew <lachlan>
Project Member
Thu 14 Jan 2016 03:43:33 PM UTC, comment #4:

@Lachlan

Just to let you know that the third output seems to be given the 'sorted' result even with the 'stable' input flag. For example,

gives

when it should give

Luis Mendo <lmendo>
Thu 14 Jan 2016 02:43:06 PM UTC, comment #3:

Thanks, Lachlan. I had already written a patched `unique` function with the 'stable' flag, but it only supports the one-output case. Yours seems to be much better. I'll check it and get back to you. Thanks!

Luis Mendo <lmendo>
Thu 14 Jan 2016 06:24:54 AM UTC, comment #2:

Louis, I've attached a new unique.m that implements Matlab's current options and defaults. As Rik said, this is just .m code; please take a look and let me know if you can see a better way to do things.

If you are about to use 'stable' in any of the other functions, please let me know so that I can prioritise them. Otherwise, they'll go in the "maybe one day" pile. Once we're done, I'll submit a patch for Rik to review.

(file #36023)

Lachlan Andrew <lachlan>
Project Member
Wed 13 Jan 2016 05:15:15 PM UTC, comment #1:

unique is implemented in an m-file (try 'which unique' inside Octave to find the exact file). This makes it very easy to change. There are no immediate plans to work on this, but if you submit a patch I can review it.

Rik <rik5>
Project Administrator
Fri 08 Jan 2016 11:56:17 PM UTC, original submission:

In recent Matlab versions, the `unique` function supports a 'stable' flag. In this mode, it returns the unique elements in the original order, not sorted. There's also a 'sorted' flag, which is the default.

The same happens with set functions: `union`, `intersect`, `setdiff`, `setxor`.

Are there any plans to include this behaviour in Octave?

Thanks for your time!

Luis Mendo <lmendo>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #36604:  setxor_comp.m added by lmendo (2KiB - application/octet-stream)
file #36605:  setdiff_comp.m added by lmendo (1KiB - application/octet-stream)
file #36606:  union_comp.m added by lmendo (1KiB - application/octet-stream)
file #36607:  intersect_comp.m added by lmendo (1KiB - application/octet-stream)
file #36302:  union_comp.m added by lmendo (1KiB - application/octet-stream)
file #36303:  intersect_comp.m added by lmendo (1KiB - application/octet-stream)
file #36304:  setdiff_comp.m added by lmendo (1KiB - application/octet-stream)
file #36305:  setxor_comp.m added by lmendo (2KiB - application/octet-stream)
file #36043:  unique.m added by lachlan (9KiB - text/x-objcsrc)
file #36023:  unique.m added by lachlan (9KiB - text/x-objcsrc)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by kpc (Posted a comment)
  • -unavailable- added by lachlan (Updated the item)
  • -unavailable- added by rik5 (Posted a comment)
  • -unavailable- added by lmendo (Submitted the item)
  • -unavailable- added by lmendo
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 12 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Fri 11 Mar 2016 09:02:04 PM UTClmendoAttached File-=>Added setxor_comp.m, #36604
      Attached File-=>Added setdiff_comp.m, #36605
      Attached File-=>Added union_comp.m, #36606
      Attached File-=>Added intersect_comp.m, #36607
    Wed 10 Feb 2016 08:50:49 PM UTClmendoAttached File-=>Added union_comp.m, #36302
      Attached File-=>Added intersect_comp.m, #36303
      Attached File-=>Added setdiff_comp.m, #36304
      Attached File-=>Added setxor_comp.m, #36305
    Fri 15 Jan 2016 07:00:56 AM UTClachlanAttached File-=>Added unique.m, #36043
    Thu 14 Jan 2016 06:24:54 AM UTClachlanAttached File-=>Added unique.m, #36023
    Wed 13 Jan 2016 05:15:15 PM UTCrik5StatusNone=>Confirmed
    Fri 08 Jan 2016 11:56:17 PM UTClmendoCarbon-Copy-=>Added -unavailable-

    Back to the top


    Powered by Savane 3.1-cleanup1