bugGforth - Bugs: bug #46722, Makefile rule to avod excess...

 
 

bug #46722: Makefile rule to avod excess rebuilds has the opposite effect

Submitted by:  None
Submitted on:  Sat 19 Dec 2015 06:09:25 PM UTC  
 
Category: NoneSeverity: 3 - Normal
Item Group: NoneStatus: Fixed
Privacy: PublicAssigned to: Bernd Paysan <paysan>
Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sat 19 Dec 2015 09:56:40 PM UTC, comment #1:

I removed that rule and generate version.fs out of a version.fs.in by the normal configure.in dependency. That may cause more stuff to be built when you change the Makefile.in, but it will now normally only execute those commands that themselves detect whether they have to do something or not (based on things make can't know).

Thanks for all those five bug reports.

Bernd Paysan <paysan>
Project AdministratorIn charge of this item.
Sat 19 Dec 2015 06:09:25 PM UTC, original submission:

The rule that tries to avoid changing the "version" file is just wrong.

As-is, whenever you change Makefile.in (without touching the version number itself), you end up in a situation where "version" is older than "Makefile.in", and <b>stays that way</b>, because the rule didn't actually update "version". But since the rule is there, and ran a command, GNU make (at least) will assume that version is now brand-new (without checking again), and therefore cause all the rules depending on "version" to re-trigger. And because the timestamp on "version" never becomes newer than that of "Makefile.in", it'll keep on doing that on every "make" run, indefinitely.

So instead of saving one rebuild per change to Makefile.in, it triggers an unlimited number of them, as soon as Makefile.in is ever touched.

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by paysan (Posted a comment)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 3 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sat 19 Dec 2015 09:56:40 PM UTCpaysanStatusNone=>Fixed
      Assigned toNone=>paysan
      Open/ClosedOpen=>Closed

    Back to the top


    Powered by Savane 3.1-cleanup1