bugfindutils - Bugs: bug #46714, make oldfind optional

 
 

bug #46714: make oldfind optional

Submitted by:  Mike Frysinger <vapier>
Submitted on:  Fri 18 Dec 2015 05:10:59 PM UTC  
 
Category: findSeverity: 2 - Minor
Item Group: NoneStatus: Fixed
Privacy: PublicAssigned to: James Youngman <jay>
Originator Name: Open/Closed: Closed
Release: 4.3.0Fixed Release: 4.5.18

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Mon 28 Dec 2015 11:07:35 AM UTC, comment #5:

Thanks for your help.

James Youngman <jay>
Project AdministratorIn charge of this item.
Mon 28 Dec 2015 11:07:13 AM UTC, comment #4:

I applied the attached patch also.

(file #35873)

James Youngman <jay>
Project AdministratorIn charge of this item.
Sun 27 Dec 2015 09:45:23 PM UTC, comment #3:

few notes:
- find/Makefile.am: using noinst_PROGRAMS means it'll still be compiled/linked. if you used check_PROGRAMS instead, that'd only happen if you did `make oldfind` or `make check`.
- whitespace in find/Makefile.am with the new line is off
- configure.ac: i would just delete the fts configure option entirely. i don't think keeping --with-fts is useful. if you delete it, configure will still warn about the flag being unknown for devs to see.
- configure.ac: whitespace is off w/new no case -- it's mixing tabs w/spaces.
- do you still need the WITH_FTS make conditional ?

Mike Frysinger <vapier>
Sun 27 Dec 2015 09:23:36 PM UTC, comment #2:

I made some additional minor changes, notably to unix.exp.

James Youngman <jay>
Project AdministratorIn charge of this item.
Sun 27 Dec 2015 08:46:33 PM UTC, comment #1:

The attached patches (which I am about to apply) do, I think, most of what you are asking:

1. configure's --with-fts option becomes a no-op.
2. Rejects configure --without-fts.
3. Retains oldfind as a test utility only (for A/B testing)
4. Renames find.c to oldfind.c for clarity

The only thing I think you asked for which these patches don't do is skip testing oldfind.

(file #35869, file #35870)

James Youngman <jay>
Project AdministratorIn charge of this item.
Fri 18 Dec 2015 05:10:59 PM UTC, original submission:

we've had the fts logic available for over 10 years now. can we get a configure option to disable building/testing/installing of the oldfind ?

Mike Frysinger <vapier>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by jay (Updated the item)
  • -unavailable- added by vapier (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 10 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Mon 28 Dec 2015 11:07:13 AM UTCjayAttached File-=>Added 0001-Apply-some-improvements-suggested-by-Mike-Frysinger.patch, #35873
    Sun 27 Dec 2015 09:36:41 PM UTCjayStatusNone=>Fixed
      Open/ClosedOpen=>Closed
      Fixed ReleaseNone=>4.5.18
    Sun 27 Dec 2015 09:23:06 PM UTCjayRelease4.5.17=>4.3.0
    Sun 27 Dec 2015 08:46:33 PM UTCjayAttached File-=>Added 0001-Remove-support-for-installing-oldfind.patch, #35869
      Attached File-=>Added 0002-Rename-find-find.c-to-find-oldfind.c.patch, #35870
      Severity3 - Normal=>2 - Minor
      Assigned toNone=>jay
      ReleaseNone=>4.5.17

    Back to the top


    Powered by Savane 3.1-cleanup1