bugGNU Octave - Bugs: bug #46431, fl-core does not build with 64 bit...

 
 

bug #46431: fl-core does not build with 64 bit enabled Octave unter Linux

Submitted by:  Martin K <grisu86>
Submitted on:  Thu 12 Nov 2015 04:27:32 PM UTC  
 
Category: Octave Forge PackageSeverity: 3 - Normal
Priority: 1 - LaterItem Group: Build Failure
Status: FixedAssigned to: John Donoghue <lostbard>
Originator Name: Open/Closed: Closed
Release: otherOperating System: GNU/Linux

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Sat 02 Jul 2016 10:50:47 PM UTC, comment #7:

CLosing as fixed as dev sources will work.

John Donoghue <lostbard>
Project MemberIn charge of this item.
Wed 29 Jun 2016 04:23:59 PM UTC, comment #6:

Pushed https://sourceforge.net/p/octave/fl-core/ci/55e9b8a341c5f62738106503e175ce3b26708acd/tree/src/fl_compose.cc?diff=10d5c65652729c8e5d4efe61726827d45f07aac8

John Donoghue <lostbard>
Project MemberIn charge of this item.
Fri 13 Nov 2015 04:31:54 PM UTC, comment #5:

Given the date of the last release, I am not sure if it currently being actively maintained?

Do we have a volunteer ?

John Donoghue <lostbard>
Project MemberIn charge of this item.
Fri 13 Nov 2015 02:41:17 PM UTC, comment #4:

Yes, there is the patch as well, but more than a year old, which is in my opinion too long because the solution is already provided.

Martin K <grisu86>
Fri 13 Nov 2015 12:49:46 PM UTC, comment #3:

It goes also with bug #41214, which I believe has a sysconf patch attached

John Donoghue <lostbard>
Project MemberIn charge of this item.
Fri 13 Nov 2015 08:12:19 AM UTC, comment #2:

The patch from #46102 fixes only the problems regarding the wrong integers but not the one with the sysconf function call. I attached a new patch only fixing this issue when the patch from #46102 is already applied.

But your patch only seems to be in the MXE Octave and not yet in the Octave-Forge package, where I think it must go to.

(file #35445)

Martin K <grisu86>
Thu 12 Nov 2015 05:21:38 PM UTC, comment #1:

I believe it probally is fixed by applying the patch from bug #46102

https://savannah.gnu.org/support/download.php?file_id=35035

John Donoghue <lostbard>
Project MemberIn charge of this item.
Thu 12 Nov 2015 04:27:32 PM UTC, original submission:

By testing more and more packages, it turned out that the fl-core package has similar integer problems as the parallel package. By installing fl-core via
the following error occurs with gcc 4.8.5 on Ubuntu 12.04:
+verbatim
mkdir (/tmp/oct-RihwiW)
untar (/afs/mpi-magdeburg.mpg.de/home/koehlerm/work/software/misc_matlab/fl-core-1.0.0.tar.gz, /tmp/oct-RihwiW)
make: Entering directory `/tmp/oct-RihwiW/fl-core/src'
mkoctfile -s fl_compose.cc
fl_compose.cc: In function ‘void sparse_compose(octave_value_list)’:
fl_compose.cc:468:67: error: call of overloaded ‘SparseMatrix(int, int, int)’ is ambiguous
sparseC = SparseMatrix((int)colsB, (int)rowsA, (int)(colsB*rowsA));
^
fl_compose.cc:468:67: note: candidates are:
In file included from /scratch/koehlerm/local_install/conda-2.7/include/octave-4.0.0/octave/../octave/mx-base.h:66:0,
from /scratch/koehlerm/local_install/conda-2.7/include/octave-4.0.0/octave/../octave/Matrix.h:30,
from /scratch/koehlerm/local_install/conda-2.7/include/octave-4.0.0/octave/../octave/oct.h:33,
from fl_compose.cc:21:
/scratch/koehlerm/local_install/conda-2.7/include/octave-4.0.0/octave/../octave/dSparse.h:90:3: note: SparseMatrix::SparseMatrix(octave_idx_type, octave_idx_type, octave_idx_type)
SparseMatrix (octave_idx_type r, octave_idx_type c,
^
/scratch/koehlerm/local_install/conda-2.7/include/octave-4.0.0/octave/../octave/dSparse.h:62:12: note: SparseMatrix::SparseMatrix(octave_idx_type, octave_idx_type, double)
explicit SparseMatrix (octave_idx_type r, octave_idx_type c, double val)
^
fl_compose.cc: In function ‘int get_available_cpus()’:
fl_compose.cc:757:19: error: ‘_SC_NPROCESSORS_ONLN’ was not declared in this scope
return sysconf( _SC_NPROCESSORS_ONLN);
^
fl_compose.cc:757:39: error: ‘sysconf’ was not declared in this scope
return sysconf( _SC_NPROCESSORS_ONLN);
-verbatim-

Beside the wrong integer size, the unistd.h header is not included to declare sysconf and _SC_NPROCESSORS_ONLN.

The attached patch will fix both problems.

Martin K <grisu86>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #35445:  flcore-fix-sysconf.diff added by grisu86 (390B - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by mtmiller (Updated the item)
  • -unavailable- added by lostbard (Posted a comment)
  • -unavailable- added by grisu86 (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 9 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sat 02 Jul 2016 10:50:47 PM UTClostbardStatusReady For Test=>Fixed
      Open/ClosedOpen=>Closed
    Wed 29 Jun 2016 04:23:59 PM UTClostbardStatusPostponed=>Ready For Test
      Assigned toNone=>lostbard
    Mon 28 Mar 2016 10:42:58 PM UTCmtmillerPriority5 - Normal=>1 - Later
      StatusNone=>Postponed
      Release4.0.0=>other
    Fri 13 Nov 2015 08:12:19 AM UTCgrisu86Attached File-=>Added flcore-fix-sysconf.diff, #35445
    Thu 12 Nov 2015 04:27:32 PM UTCgrisu86Attached File-=>Added flcore-octave_idx_type.patch, #35442

    Back to the top


    Powered by Savane 3.1-cleanup1