bugmake - Bugs: bug #46203, Patch to make -j value visible to...

 
 

bug #46203: Patch to make -j value visible to make

Submitted by:  Emanuele Santoro <esantoro>
Submitted on:  Tue 13 Oct 2015 06:19:44 PM UTC  
 
Severity: 3 - NormalItem Group: Enhancement
Status: FixedPrivacy: Public
Assigned to: Paul D. Smith <psmith>Open/Closed: Closed
Component Version: 4.1Operating System: Any
Fixed Release: 4.2Triage Status: Medium Effort

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Mon 04 Apr 2016 05:52:28 AM UTC, comment #1:

I decided to do this differently. Instead of creating a new variable I just modified make to ensure that the -jN flag was present in MAKEFLAGS and N was correct.

You can get the value using something like:

This will be in the next release.

Paul D. Smith <psmith>
Project AdministratorIn charge of this item.
Tue 13 Oct 2015 06:19:44 PM UTC, original submission:

Hi!

I implemented a patch for GNU Make providing the value of the -j command line option via the #J variable inside the Makefile (I implemented the #J variable).

It would be lovely to see this patch merged in the main source tree.

Attached is the patch implementing this. I have tested on my laptop (Ubuntu 14.04, x86_64) and the test suite passes:

Regression PASSED: GNU Make 4.1.90 (x86_64-unknown-linux-gnu) built with gcc

I am not 100% sure this is done correctly, it's my first contribution to GNU Make and the first time I am using Savannah.

Please review this patch and tell me if I can improve it in any way for inclusion in the main source tree.

Thanks in advance,
--
Emanuele Santoro

Emanuele Santoro <esantoro>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #35186:  0001-Implemented-J-automatic-variable-for-number-of-concu.patch added by esantoro (3KiB - text/x-patch - The patch implementing the #J variable)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by psmith (Updated the item)
  • -unavailable- added by esantoro (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 7 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Mon 04 Apr 2016 05:52:28 AM UTCpsmithStatusNone=>Fixed
      Assigned toNone=>psmith
      Open/ClosedOpen=>Closed
      Fixed ReleaseNone=>4.2
      Triage StatusNone=>Medium Effort
    Mon 29 Feb 2016 03:28:44 AM UTCpsmithSummaryPatch=>Patch to make -j value visible to make
    Tue 13 Oct 2015 06:19:44 PM UTCesantoroAttached File-=>Added 0001-Implemented-J-automatic-variable-for-number-of-concu.patch, #35186

    Back to the top


    Powered by Savane 3.1-cleanup1