bugGNU Wget - Bugs: bug #46161, make check fails due to missing...

 
 

bug #46161: make check fails due to missing library in tests/Makefile link command

Submitted by:  None
Submitted on:  Thu 08 Oct 2015 08:03:57 PM UTC  
 
Category: Build/InstallSeverity: 3 - Normal
Priority: 5 - NormalStatus: Invalid
Privacy: PublicAssigned to: Tim Ruehsen <rockdaboot>
Originator Name: Kevin RodgersOriginator Email: -unavailable-
Open/Closed: ClosedRelease: 1.16
Operating System: GNU/LinuxReproducibility: Every Time
Fixed Release: trunkPlanned Release: None
Regression: NoneWork Required: None
Patch Included: Yes

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Fri 09 Oct 2015 08:10:10 AM UTC, comment #1:

Thanks for having a look.

But tests/Makefile is an auto-generated file (generated from Makefile.am). So it is definitely the wrong place to fix anything.

And please always check the latest source code from git, the problem might have already been fixed.

How to get the sources from git:
https://savannah.gnu.org/git/?group=wget

After downloading the sources you should read README.checkout to proceed.
If you still have problems to compile/link, feel free to open a new issue.

Tim Ruehsen <rockdaboot>
Project AdministratorIn charge of this item.
Thu 08 Oct 2015 08:03:57 PM UTC, original submission:

Here is the relevant output from "make check":

Making check in tests
make[2]: Entering directory `/tmp/wget-1.16/tests'
make unit-tests
make[3]: Entering directory `/tmp/wget-1.16/tests'
cd ../src && make libunittest.a
make[4]: Entering directory `/tmp/wget-1.16/src'
make[4]: `libunittest.a' is up to date.
make[4]: Leaving directory `/tmp/wget-1.16/src'
gcc -g -O2 -o unit-tests ../src/libunittest.a ../lib/libgnu.a -lz -luuid -lz -luuid
../src/libunittest.a(libunittest_a-ptimer.o)(.text+0x34): In function `posix_init':
/tmp/wget-1.16/src/ptimer.c:145: undefined reference to `clock_getres'
../src/libunittest.a(libunittest_a-ptimer.o)(.text+0x14e): In function `ptimer_reset':
/tmp/wget-1.16/src/ptimer.c:169: undefined reference to `clock_gettime'
../src/libunittest.a(libunittest_a-ptimer.o)(.text+0x18d): In function `ptimer_measure':
/tmp/wget-1.16/src/ptimer.c:169: undefined reference to `clock_gettime'
collect2: ld returned 1 exit status
make[3]: *** [unit-tests] Error 1
make[3]: Leaving directory `/tmp/wget-1.16/tests'
make[2]: *** [check-am] Error 2
make[2]: Leaving directory `/tmp/wget-1.16/tests'

And here is the patch to fix it:

--- tests/Makefile.orig 2015-10-07 16:29:44.000000000 -0600
+++ tests/Makefile 2015-10-07 16:50:02.000000000 -0600
@@ -1546,7 +1546,7 @@

unit-tests$(EXEEXT): $(unit_tests_OBJECTS) $(unit_tests_DEPENDENCIES) $(EXTRA_unit_tests_DEPENDENCIES)
@rm -f unit-tests$(EXEEXT)
- $(AM_V_CCLD)$(LINK) $(unit_tests_OBJECTS) $(unit_tests_LDADD) $(LIBS)
+ $(AM_V_CCLD)$(LINK) $(unit_tests_OBJECTS) $(unit_tests_LDADD) $(LIBS) $(LIB_CLOCK_GETTIME)

mostlyclean-compile:
-rm -f *.$(OBJEXT)

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by rockdaboot (Posted a comment)
  • -unavailable- added by None (Submitted the item)
  •  

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 5 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Tue 03 Nov 2015 02:17:01 PM UTCrockdabootOpen/ClosedOpen=>Closed
      Fixed Release1.16.3=>trunk
    Fri 09 Oct 2015 08:10:10 AM UTCrockdabootStatusNone=>Invalid
      Assigned toNone=>rockdaboot
      Fixed ReleaseNone=>1.16.3

    Back to the top


    Powered by Savane 3.1-cleanup1