bugGNU Octave - Bugs: bug #46054, make rules for *.df ignore user...

 
 

bug #46054: make rules for *.df ignore user CXXFLAGS

Submitted by:  Carnë Draug <carandraug>
Submitted on:  Sat 26 Sep 2015 03:51:57 PM UTC  
 
Category: Configuration and Build SystemSeverity: 3 - Normal
Priority: 5 - NormalItem Group: Build Failure
Status: FixedAssigned to: None
Originator Name: Open/Closed: Closed
Release: devOperating System: GNU/Linux

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Mon 28 Sep 2015 08:27:37 AM UTC, comment #2:

ok. I pushed the patch.

Carnë Draug <carandraug>
Project Member
Mon 28 Sep 2015 12:24:58 AM UTC, comment #1:

The patch looks good to me. I think it was just an oversight when jwe transitioned away from recursive make. The code duplication isn't a problem.

Rik <rik5>
Project Administrator
Sat 26 Sep 2015 03:51:57 PM UTC, original submission:

The rules for df do not make use of the user defined CXXFLAGS. This is working fine in the stable branch. The reason is that these got dropped when removing the recursive make:

http://hg.savannah.gnu.org/hgweb/octave/rev/0ce7d8303152#l5.534

http://hg.savannah.gnu.org/hgweb/octave/rev/0ce7d8303152#l9.362

http://hg.savannah.gnu.org/hgweb/octave/rev/0ce7d8303152#l10.265

The attached changeset fixes the issue. However, I also noticed that these 3 rules are quite similar among them so maybe there's a better way to do this that would avoid code duplication?

One of this issue was causing a build failure, and I found the other two by running the following on the build tree (but maybe this is still missing some other cases?)

Carnë Draug <carandraug>
Project Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #34990:  df-cxxflags.cset added by carandraug (2KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by rik5 (Posted a comment)
  • -unavailable- added by carandraug (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 3 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Mon 28 Sep 2015 08:27:37 AM UTCcarandraugStatusPatch Submitted=>Fixed
      Open/ClosedOpen=>Closed
    Sat 26 Sep 2015 03:51:57 PM UTCcarandraugAttached File-=>Added df-cxxflags.cset, #34990

    Back to the top


    Powered by Savane 3.1-cleanup1