bugGNU nano - Bugs: bug #45874, searching for a string in a binary...

 
 

bug #45874: searching for a string in a binary file causes Babylon

Submitted by:  Benno Schulenberg <bens>
Submitted on:  Fri 04 Sep 2015 10:27:14 AM UTC  
 
Severity: 5 - BlockerStatus: Fixed
Assigned to: Benno Schulenberg <bens>Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Fri 04 Sep 2015 07:44:05 PM UTC, comment #1:

Fixed in SVN, r5369. It reverts the commit that said that UTF8 is a stateless encoding. Maybe only one of the resets is needed, hopefully wctomb_reset(), but I don't have the time to test that out thoroughly now.

Also, if these resets are needed, they may be required elsewhere in the code too: stepping a multibyte character to the left is likely to hit an invalid code, but it probably does not reset the state then. I haven't yet seen any ill effects, but...

Benno Schulenberg <bens>
Project AdministratorIn charge of this item.
Fri 04 Sep 2015 10:27:14 AM UTC, original submission:

Open a .odt file with nano -- the screen will be filled with binary garbage. Now search for some string that most likely does not exist in the document, say "owow". The screen will now be filled with reverse-video question marks, and even the status line will be garbled: [ ������ ��� ����� ].

Somehow nano loses it entirely in the presence of loads of invalid UTF-8. Only current SVN has this, 2.4.2 and before are fine.

Benno Schulenberg <bens>
Project AdministratorIn charge of this item.

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by bens (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 2 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Mon 07 Dec 2015 03:17:04 PM UTCbensOpen/ClosedOpen=>Closed
    Fri 04 Sep 2015 07:44:05 PM UTCbensStatusNone=>Fixed

    Back to the top


    Powered by Savane 3.1-cleanup1