bugGNU GRUB - Bugs: bug #45729, Reboot or hang when missing...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #45729: Reboot or hang when missing network modules

Submitted by:  Jason Tang <dev_null42>
Submitted on:  Tue 11 Aug 2015 12:31:27 AM UTC  
 
Category: NetworkSeverity: Major
Priority: 5 - NormalItem Group: Software Error
Status: FixedPrivacy: Public
Assigned to: NoneOriginator Name: Jason Tang
Open/Closed: ClosedRelease: 
Release: Git masterReproducibility: Every Time
Planned Release: None

Thu 13 Aug 2015 05:24:01 PM UTC, comment #3:

Fixed in ba218c1c10833092b14177896c10e48715c836fe. Regarding message - patches are welcome :)

Thanks for the report!

Andrei Borzenkov <arvidjaar>
Project Member
Thu 13 Aug 2015 03:57:58 PM UTC, comment #2:

Yes, the patch fixes the problem. I would have preferred it also display a message, but nonetheless GRUB no longer crashes.

Tested-by: Jason Tang <tang@jtang.org.>

Jason Tang <dev_null42>
Wed 12 Aug 2015 05:52:54 PM UTC, comment #1:

Please test attached patch. It fixes it for me.

(file #34631)

Andrei Borzenkov <arvidjaar>
Project Member
Tue 11 Aug 2015 12:31:27 AM UTC, original submission:

On a modern x86 UEFI system, I tried PXE booting GRUB2. After the "Welcome to GRUB!" message, GRUB would either (a) reboot itself, (b) hang, or (c) go into an infinite loop. I traced the problem down to grub-core/net/net.c, in grub_net_open_real(). I had accidentally not included the TFTP module into bootx64.efi.

There is no error checking on the call to grub_dl_load() for tftp (nor http). If the load fails, GRUB continues running and seems to corrupt its call stack, thus accounting for the observed inconsistent behavior. I propose that the code should check the return value to grub_dl_load(). If it is zero, then GRUB should panic and go into a failure mode, instead of continuing.

Jason Tang <dev_null42>

 

Attached Files
file #34631:  45729.patch added by arvidjaar (1KiB - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by arvidjaar (Updated the item)
  • -unavailable- added by dev_null42 (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 3 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Thu 13 Aug 2015 05:24:01 PM UTCarvidjaarStatusNone=>Fixed
      Open/ClosedOpen=>Closed
    Wed 12 Aug 2015 05:52:54 PM UTCarvidjaarAttached File-=>Added 45729.patch, #34631

    Back to the top


    Powered by Savane 3.1-cleanup1