bugGNU Octave - Bugs: bug #45574, 'make maintainer-clean' does not...

 
 

bug #45574: 'make maintainer-clean' does not remove all temporary doc files

Submitted by:  Rik <rik5>
Submitted on:  Sat 18 Jul 2015 04:16:24 PM UTC  
 
Category: Configuration and Build SystemSeverity: 3 - Normal
Priority: 5 - NormalItem Group: Regression
Status: FixedAssigned to: John W. Eaton <jwe>
Originator Name: Open/Closed: Closed
Release: devOperating System: GNU/Linux

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Mon 03 Aug 2015 04:27:17 AM UTC, comment #5:

Mike, not a problem. I've updated to the most recent tip and verified that 'make maintainer-clean' is removing all of the temporary doc files.

Rik <rik5>
Project Administrator
Sun 02 Aug 2015 04:18:30 PM UTC, comment #4:

Rik, I ended up reverting most of this change, but I hope it ends up being effectively the same solution done differently. I know you are still on Automake 1.11. Automake 1.13 introduced the --build-dir option to make sure the texi2* rules can run in parallel, around the same time we added custom code to handle that in Octave in 2012. I just pushed http://hg.savannah.gnu.org/hgweb/octave/rev/44a1281e6e76 which moves the --build-dir option back to the makefile and uses the naming convention that Automake uses so we can try to match what they use as closely as possible. I hope this doesn't break anything for your build with your version of Automake.

Mike Miller <mtmiller>
Project Administrator
Tue 21 Jul 2015 07:27:58 PM UTC, comment #3:

I changed the definitions of TEXI2DVI and TEXI2PDF in acinclude.m4 so that each uses a differently named build-dir. This allows them to run in parallel. I also added a rule to clean up these temporary cache directories under the doc-clean target. See this cset (http://hg.savannah.gnu.org/hgweb/octave/rev/07ddaaeb9040).

Closing report.

Rik <rik5>
Project Administrator
Mon 20 Jul 2015 09:41:16 PM UTC, comment #2:

I see that your changeset

http://hg.savannah.gnu.org/hgweb/octave/rev/87f337783d95

introduced t2d_cache, presumably sharing makeinfo intermediate files sped up the build? This change also forced the build to be done sequentially because of that very reason.

The current build has

So looks like the t2d_cache is not being used anymore, at least by the doc/interpreter and doc/liboctave builds.

And I think the reason for overriding the --build-dir option is so the subdirectory is used rather than making the intermediate directory at the top-level.

I know that we can't use NOTPARALLEL anymore since we are non-recursive now, but I don't know what the current tradeoffs are in terms of sharing files between a couple of makeinfo calls versus being able to execute them in parallel. Especially now that we could have users building with Texinfo version 4, 5, or 6.

Mike Miller <mtmiller>
Project Administrator
Sat 18 Jul 2015 04:23:20 PM UTC, comment #1:

If I look at the Makefile, I see that the rules that use texi2dvi and texi2pdf have been overridden by new versions in doc/module.mk. This seems to be the source of the problem, although I don't know the solution.

Rik <rik5>
Project Administrator
Sat 18 Jul 2015 04:16:24 PM UTC, original submission:

If I do 'make maintainer-clean' followed by 'hg stat -u > u.list' to get a list of the unknown files not tracked by Mercurial, I find three directories of files.

./t2d_cache
./doc/interpreter/octave.t2d
./doc/interpreter/octave.t2p

If I go back to the stable branch, I find that there was a local rule for the doc/interpreter directory

The new build system doesn't appear to use '-local' rules so this seems to have been lost.

The octave.t2d and octave.t2p directories seem to be related to calling texi2dvi and texi2pdf. See this discussion (http://octave.1599824.n4.nabble.com/Building-documentation-in-parallel-td4643470.html) and the changeset that is referenced in the discussion. It seems that the change to the definitions of the build variables TEXI2DVI and TEXI2PDF in m4/acinclude.m4 are no longer being recognized.

Rik <rik5>
Project Administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by mtmiller (Posted a comment)
  • -unavailable- added by rik5 (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 2 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Tue 21 Jul 2015 07:27:58 PM UTCrik5StatusNone=>Fixed
      Open/ClosedOpen=>Closed

    Back to the top


    Powered by Savane 3.1-cleanup1