bugGNU Octave - Bugs: bug #45545, The listdlg items can no longer be...

 
 

bug #45545: The listdlg items can no longer be selected

Submitted by:  Dan Sebald <sebald>
Submitted on:  Tue 14 Jul 2015 08:19:10 AM UTC  
 
Category: GUISeverity: 3 - Normal
Priority: 5 - NormalItem Group: Incorrect Result
Status: FixedAssigned to: None
Originator Name: Open/Closed: Closed
Release: devOperating System: GNU/Linux

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Fri 17 Jul 2015 12:05:23 AM UTC, comment #7:

Pushed the cset here (http://hg.savannah.gnu.org/hgweb/octave/rev/63736167fb78). Closing report.

Rik <rik5>
Project Administrator
Wed 15 Jul 2015 07:09:37 PM UTC, comment #6:

Yes, the changeset works. Changing the test to case-sensitive is a good idea because then the cross-thread option is forced to agree with the C++ code.

Dan Sebald <sebald>
Wed 15 Jul 2015 04:58:52 AM UTC, comment #5:

Does the attached changeset fix the problem for you?

(file #34447)

Rik <rik5>
Project Administrator
Tue 14 Jul 2015 07:23:54 PM UTC, comment #4:

The changeset making the mod to case insensitive is here:

http://hg.savannah.gnu.org/hgweb/octave/rev/8bfadb26afcd

So maybe changing

selmode = "Multiple"

to

selmode = "multiple"

is more along that line. But I'm sure there is an easy way to make the C++/Qt code test case insensitive. E.g.,

http://doc.qt.io/qt-4.8/qstring.html#compare-6

Dan Sebald <sebald>
Tue 14 Jul 2015 06:55:38 PM UTC, comment #3:

Hold on. There is a bug here still. The third example doesn't have SelectionMode specified. The default is set to "Multiple", i.e.,

and the comparison within the script file is case insensitive:

although I'm pretty sure the intent was for the comparison to be case sensitive, with there being

But the comparison in C/Qt code is case sensitive.

There are two solutions here. Either change

selmode = "Multiple"

to

selmode = "multiple"

or modify the C/Qt code to do a case-insensitive comparison. I'm inclined to change to the latter because this bug arising is already indicative a the source of confusion. Which is preferred?

Dan Sebald <sebald>
Tue 14 Jul 2015 06:30:19 PM UTC, comment #2:

Oh, this one was a replicated file in my local ~/octave directory. No bug. Please close.

Dan Sebald <sebald>
Tue 14 Jul 2015 08:20:03 AM UTC, comment #1:

Qt version of listdlg is what I was referring to.

Dan Sebald <sebald>
Tue 14 Jul 2015 08:19:10 AM UTC, original submission:

In running a demo that utilized the listdlg, I was unable to modify the selected items in the list. The behavior is also evident in the listdlg demo, i.e.,

Dan Sebald <sebald>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #34447:  selmode.cset added by rik5 (1KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by rik5 (Updated the item)
  • -unavailable- added by sebald (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 4 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Fri 17 Jul 2015 12:05:23 AM UTCrik5StatusPatch Submitted=>Fixed
      Open/ClosedOpen=>Closed
    Wed 15 Jul 2015 04:58:52 AM UTCrik5Attached File-=>Added selmode.cset, #34447
      StatusNone=>Patch Submitted

    Back to the top


    Powered by Savane 3.1-cleanup1