bugGNU Octave - Bugs: bug #45378, Tests for z_test_2.m.

 
 

bug #45378: Tests for z_test_2.m.

Submitted by:  Allan Jacobs <allanjacobs>
Submitted on:  Mon 22 Jun 2015 07:20:02 PM UTC  
 
Category: Octave FunctionSeverity: 2 - Minor
Priority: 5 - NormalItem Group: Other
Status: FixedAssigned to: None
Originator Name: allanjacobsOpen/Closed: Closed
Release: devOperating System: Any

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Fri 11 Aug 2017 06:28:43 PM UTC, comment #4:

The test failure(s) were due to a couple of typos. I fixed those and pushed the changeset here:

http://hg.savannah.gnu.org/hgweb/octave/rev/89a1ed157a2a

John W. Eaton <jwe>
Project Administrator
Wed 18 Jan 2017 05:04:13 PM UTC, comment #3:

Opening this bug report. Seems to be close by mistake

Avinoam Kalma <avinoam>
Project Member
Mon 29 Jun 2015 03:41:01 AM UTC, comment #2:

I reviewed the patch and made some changes. First, Octave uses a space between the name of the function and the opening parenthesis in order to distinguish from the case of indexing a variable. I added appropriate spaces. Second, the code failed to run. I used 'test z_test_2' from within Octave and apparently there were different names for the same variable 'nx' and 'n_x'. I renamed 'nx' to 'n_x' and 'ny' to 'n_y' and now the code runs, but it produces the error below.

Since I don't particularly understand what the tolerance should be, I am returning the updated changeset to this bug report. See the attached file.

(file #34336)

Rik <rik5>
Project Administrator
Thu 25 Jun 2015 05:02:41 PM UTC, comment #1:

Thanks for your contribution. Marking as having a patch submitted, someone will review your change and provide feedback or merge it into the Octave repo.

Mike Miller <mtmiller>
Project Administrator
Mon 22 Jun 2015 07:20:02 PM UTC, original submission:

Six tests for z_test_2.m are added. Three are derived from those in z_test.m. The source code difference file z_test_2.diff is attached.

Allan Jacobs <allanjacobs>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #34336:  z_test_2.cset added by rik5 (3KiB - application/octet-stream)
file #34296:  z_test_2.diff added by allanjacobs (3KiB - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by jwe (Posted a comment)
  • -unavailable- added by avinoam (Posted a comment)
  • -unavailable- added by rik5 (Updated the item)
  • -unavailable- added by mtmiller (Posted a comment)
  • -unavailable- added by allanjacobs (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 9 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Fri 11 Aug 2017 06:28:43 PM UTCjweStatusPatch Submitted=>Fixed
      Open/ClosedOpen=>Closed
    Wed 18 Jan 2017 05:04:13 PM UTCavinoamOpen/ClosedClosed=>Open
    Tue 22 Sep 2015 12:31:20 PM UTCrik5Open/ClosedOpen=>Closed
    Mon 29 Jun 2015 03:41:01 AM UTCrik5Attached File-=>Added z_test_2.cset, #34336
    Thu 25 Jun 2015 05:02:41 PM UTCmtmillerSeverity3 - Normal=>2 - Minor
      Item GroupNone=>Other
      StatusNone=>Patch Submitted
    Mon 22 Jun 2015 07:20:03 PM UTCallanjacobsAttached File-=>Added z_test_2.diff, #34296

    Back to the top


    Powered by Savane 3.1-cleanup1