bugGNU Octave - Bugs: bug #45332, missing function hook says that...

 
 

bug #45332: missing function hook says that "upsample" is in control package, but actually in signal

Submitted by:  None
Submitted on:  Tue 16 Jun 2015 12:15:49 PM UTC  
 
Category: Octave FunctionSeverity: 2 - Minor
Priority: 3 - LowItem Group: Documentation
Status: ConfirmedAssigned to: None
Originator Name: Originator Email: -unavailable-
Open/Closed: OpenRelease: dev
Operating System: Any

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Tue 16 Jun 2015 06:37:10 PM UTC, comment #4:

Right, the point is that the one in the signal package is a "bare" function that operates on vectors, and the placeholder for the one in the control package would operate on control system classes (either @lti/upsample.m or @tf/upsample.m). But the missing function hook in Octave only matches against the simple function name, it has no idea whether it should be an ordinary function or a class method or a class constructor, etc.

There are lots of duplicates in the _unimplemented_.m function file now that I am looking for them. Functions like get, set, log, size probably don't need to be listed there. Upsample shows up in both control and signal. Step shows up in both control and statistics. The statistics section actually has a lot of self-duplicates, e.g. "predict" is listed 8 times in a row.

Mike Miller <mtmiller>
Project Administrator
Tue 16 Jun 2015 05:54:50 PM UTC, comment #3:

There was a nice post on abandonmatlab named "My kingdom for a namespace" that complained about Mathworks inability to avoid clash of function names between their own products. Too bad it had to go private:

https://abandonmatlab.wordpress.com/category/my-kingdom-for-a-namespace/

On the specific of the problems, someone with Matlab will have to check but I will guess that the upsample of the control package would have to be implemented as method for model classes, i.e., in @tf/upsample.m

Carnë Draug <carandraug>
Project Member
Tue 16 Jun 2015 05:35:00 PM UTC, comment #2:

Wouldn't this (= control pkg also having "upsample") be a clear case of a namespace clash?

OF signal is even dependent on OF control.

Philip Nienhuis <philipnienhuis>
Project Member
Tue 16 Jun 2015 04:23:43 PM UTC, comment #1:

That's not entirely true. The control package could also have an upsample function, a method for models. And indeed it is still unimplemented.

When you call the function on the octave interpreter, we can't guess which one you will want.

Carnë Draug <carandraug>
Project Member
Tue 16 Jun 2015 12:15:49 PM UTC, original submission:

>> help upsample
error: help: the 'upsample' function belongs to the control package from Octave
Forge which you have installed but not loaded. To load the package, run
`pkg load control' from the Octave prompt.

Please read `http://www.octave.org/missing.html' to learn how you can
contribute missing functionality.

>> pkg load control
>> help upsample

error: help: the 'upsample' function belongs to the control package from Octave
Forge but has not yet been implemented.

Please read `http://www.octave.org/missing.html' to learn how you can
contribute missing functionality.

>> pkg load signal
>> help upsample

'upsample' is a function from the file C:\Octave\Octave-4.0.0\share\octave\packages\signal-1.3.2\upsample.m

-- Function File: Y = upsample (X, N)
-- Function File: Y = upsample (X, N, OFFSET)
Upsample the signal, inserting N-1 zeros between every element.

If X is a matrix, upsample every column.

If OFFSET is specified, control the position of the inserted
sample in the block of N zeros.

See also: decimate, downsample, interp, resample, upfirdn.

Additional help for built-in functions and operators is
available in the online version of the manual. Use the command
'doc <topic>' to search the manual index.

Help and information about Octave is also available on the WWW
at http://www.octave.org and via the -unavailable-
mailing list.

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by mtmiller (Posted a comment)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 7 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Tue 22 Dec 2015 05:55:28 PM UTCmtmillerSummaryUpsample in signal package, not control=>missing function hook says that "upsample" is in control package, but actually in signal
    Tue 16 Jun 2015 06:37:10 PM UTCmtmillerCategoryOctave Forge Package=>Octave Function
      Severity3 - Normal=>2 - Minor
      Priority5 - Normal=>3 - Low
      StatusNone=>Confirmed
      Release4.0.0=>dev
    Tue 16 Jun 2015 04:23:43 PM UTCcarandraugOperating SystemMicrosoft Windows=>Any

    Back to the top


    Powered by Savane 3.1-cleanup1