bugGNU Octave - Bugs: bug #45261, cannot close figure after multiple...

 
 

bug #45261: cannot close figure after multiple calls to ginput()

Submitted by:  Philip Nienhuis <philipnienhuis>
Submitted on:  Fri 05 Jun 2015 07:25:02 PM UTC  
 
Category: Plotting with OpenGLSeverity: 3 - Normal
Priority: 5 - NormalItem Group: Regression
Status: FixedAssigned to: None
Originator Name: Philip NienhuisOpen/Closed: Closed
Release: devOperating System: Any

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sat 06 Jun 2015 03:40:40 PM UTC, comment #5:

Thanks for the quick fix!

Philip Nienhuis <philipnienhuis>
Project Member
Sat 06 Jun 2015 03:28:02 PM UTC, comment #4:

Sorry, I forgot to restore the original closereq function at the end of a normal termination of ginput. I fixed that here (http://hg.savannah.gnu.org/hgweb/octave/rev/b93a155dc200) and I can now run ginput more than once.

Rik <rik5>
Project Administrator
Sat 06 Jun 2015 02:27:47 PM UTC, comment #3:

Ok, confirmed here. Also affects FLTK toolkit. The error is due to this change:

http://hg.savannah.gnu.org/hgweb/octave/rev/2283dd03bf50

but I haven't even glanced at the diff to see what might be the cause.

Mike Miller <mtmiller>
Project Administrator
Sat 06 Jun 2015 12:43:03 PM UTC, comment #2:

You're right, works in 4.0.0 but not in dev (4.1.0+)

BTW plot ... isn't even required, just ginput(1) twice will do the trick.

Adapting "release"

Philip Nienhuis <philipnienhuis>
Project Member
Sat 06 Jun 2015 02:05:21 AM UTC, comment #1:

I don't get the error you're seeing with 4.0.0. Qt toolkit, with or without GUI running? I ran the commands in your example and the figure closed without any error.

Mike Miller <mtmiller>
Project Administrator
Fri 05 Jun 2015 07:25:02 PM UTC, original submission:

Steps to reproduce:

Looking in ginput.m in debug mode, I see that variable orig_closerequestfcn, that is a string "close_req" after the first call, is turned into a cell array that upon each following call to ginput gets nested deeper in the following fashion:

While I'm overall almost clueless about Octave's graphics innards, I think the error message clearly indicates that feval doesn't expect a cell array. The call in L.73:

seems to be the culprit as it is there where the cell array is produced.

Closing a figure after multiple calls to ginput() used to work, hence "regression"

Philip Nienhuis <philipnienhuis>
Project Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by rik5 (Posted a comment)
  • -unavailable- added by mtmiller (Posted a comment)
  • -unavailable- added by philipnienhuis (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 6 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sat 06 Jun 2015 03:28:02 PM UTCrik5StatusConfirmed=>Fixed
      Open/ClosedOpen=>Closed
    Sat 06 Jun 2015 02:27:47 PM UTCmtmillerStatusWorks For Me=>Confirmed
      SummaryQt: cannot close figure after multiple calls to ginput()=>cannot close figure after multiple calls to ginput()
    Sat 06 Jun 2015 12:43:03 PM UTCphilipnienhuisRelease4.0.0=>dev
    Sat 06 Jun 2015 02:05:21 AM UTCmtmillerStatusNone=>Works For Me

    Back to the top


    Powered by Savane 3.1-cleanup1