bugGNUstep - Bugs: bug #45122, [back][patch] Pattern phase support

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #45122: [back][patch] Pattern phase support

Submitted by:  Josh Freeman <tedge>
Submitted on:  Sun 17 May 2015 09:41:52 PM UTC  
 
Category: BackendSeverity: 3 - Normal
Item Group: Change RequestStatus: Fixed
Privacy: PublicAssigned to: Fred Kiefer <FredKiefer>
Open/Closed: Closed

Fri 22 May 2015 09:14:10 PM UTC, comment #2:

Thank you for providing this excellent patch. I just commited it to SVN.
If you have future patchs to GNUstep, there is a specific category for that in Savannah. Feel free to submit them there.

Fred Kiefer <FredKiefer>
Project MemberIn charge of this item.
Sun 17 May 2015 10:05:19 PM UTC, comment #1:

Sorry, typo in the title - this is a backend issue, not base; Title should read:
[back][patch] Pattern phase support

Josh Freeman <tedge>
Sun 17 May 2015 09:41:52 PM UTC, original submission:

Setup: VirtualBox 4.3 + Ubuntu 14.04 guest, Clang, current SVN trunk

Patch adds support for the NSGraphicsContext's patternPhase offset when drawing a pattern. (Patterns are currently always drawn with zero offset, regardless of the draw context's patternPhase value).

Pattern phase is useful for scrolling or animating a pattern-filled area, as well as for tiling a pattern that's pinned to a nonzero origin.

Patch also corrects a minor issue with getting the pattern size: The size message is sent to a safer target object - the received parameter, pattern_image - instead of the instance member, pattern. (Seems like they're always the same object, but it's safer not to assume this).

Test program is also attached.

Josh Freeman <tedge>

 

Attached Files
file #34039:  TestPatternPhase.m added by tedge (2KiB - text/x-objcsrc)
file #34038:  back_PatternPhase.patch added by tedge (2KiB - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by FredKiefer (Posted a comment)
  • -unavailable- added by tedge (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 9 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sat 18 Nov 2017 02:56:40 PM UTCFredKieferStatusReady For Test=>Fixed
      Open/ClosedIn Test=>Closed
    Fri 22 May 2015 09:14:10 PM UTCFredKieferItem GroupBug=>Change Request
      StatusNone=>Ready For Test
      Assigned toNone=>FredKiefer
      Open/ClosedOpen=>In Test
      Summary[base][patch] Pattern phase support=>[back][patch] Pattern phase support
    Sun 17 May 2015 09:41:52 PM UTCtedgeAttached File-=>Added back_PatternPhase.patch, #34038
      Attached File-=>Added TestPatternPhase.m, #34039

    Back to the top


    Powered by Savane 3.1-cleanup1