bugGNU Octave - Bugs: bug #45087, image package: rangefilt does...

 
 

bug #45087: image package: rangefilt does incorrect

Submitted by:  Hartmut <hardy>
Submitted on:  Tue 12 May 2015 08:29:01 PM UTC  
 
Category: Octave Forge PackageSeverity: 3 - Normal
Priority: 5 - NormalItem Group: Incorrect Result
Status: FixedAssigned to: None
Originator Name: Open/Closed: Closed
Release: 4.0.0Operating System: Any

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Tue 02 Jun 2015 04:10:10 PM UTC, comment #7:

Retagging release from 4.0.0-rc4 to 4.0.0.

John W. Eaton <jwe>
Project Administrator
Sun 24 May 2015 04:20:46 PM UTC, comment #6:

Thank you, I had fixed it with

http://hg.code.sf.net/p/octave/image/rev/b348244c0153

I have now pushed your suggested test

http://hg.code.sf.net/p/octave/image/rev/3a088259e167

Carnë Draug <carandraug>
Project Member
Wed 13 May 2015 09:59:46 AM UTC, comment #5:

The same problem is in stdfilt.m, line 55.

The same test works here.

Avinoam Kalma <avinoam>
Project Member
Wed 13 May 2015 12:04:43 AM UTC, comment #4:

Thank you for this. I have pushed it into the stable branch

http://hg.code.sf.net/p/octave/image/rev/953d8f19ca37

Unfortunately, I wouldn't be surprised if there weren't more locations like this (this is not the first time such bug creeps in), but specially old functions don't have tests.

Carnë Draug <carandraug>
Project Member
Tue 12 May 2015 09:07:23 PM UTC, comment #3:

Sorry, I did not see the patch :-(

Avinoam Kalma <avinoam>
Project Member
Tue 12 May 2015 08:48:51 PM UTC, comment #2:

Yes, this is half of the content if my attached patch :)

The interesting question is, if this bug maybe apears in multiple other m-files of the image package! I think this type of input check has been changed for Octave-4.0.0 compatibility. But because Octave 4.0.0 has not been released yet, there is hardly any testing done on image-2.4.0 so far.

Hartmut <hardy>
Tue 12 May 2015 08:45:31 PM UTC, comment #1:

At the beginning of rangefilt.m

It seems that it should be && and not ||, or

Avinoam Kalma <avinoam>
Project Member
Tue 12 May 2015 08:29:01 PM UTC, original submission:

Here is a little script to show the behavior (image 2.4.0 under Octave 4.0.0-rc4):

The result is an error message. I think this is only due to incorrect input checks in rangefilt.m . I will attach a patch to correct this.

But it might be worth to check all other functions in the image package for this same type of bug!

Hartmut <hardy>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #33990:  rangefilt_inputchecks.diff added by hardy (1KiB - text/x-diff)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by jwe (Posted a comment)
  • -unavailable- added by avinoam (Posted a comment)
  • -unavailable- added by hardy (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 4 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Tue 02 Jun 2015 04:10:10 PM UTCjweRelease4.0.0-rc4=>4.0.0
    Wed 13 May 2015 12:04:43 AM UTCcarandraugStatusNone=>Fixed
      Open/ClosedOpen=>Closed
    Tue 12 May 2015 08:29:01 PM UTChardyAttached File-=>Added rangefilt_inputchecks.diff, #33990

    Back to the top


    Powered by Savane 3.1-cleanup1