bugGNU Octave - Bugs: bug #44976, configure test for sndfile not...

 
 

bug #44976: configure test for sndfile not good enough

Submitted by:  CarnĂ« Draug <carandraug>
Submitted on:  Fri 01 May 2015 11:34:55 AM UTC  
 
Category: Configuration and Build SystemSeverity: 3 - Normal
Priority: 5 - NormalItem Group: Build Failure
Status: FixedAssigned to: Rik <rik5>
Originator Name: Open/Closed: Closed
Release: 4.0.0Operating System: GNU/Linux

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Tue 02 Jun 2015 04:11:02 PM UTC, comment #5:

Retagging release from 4.0.0-rc4 to 4.0.0.

John W. Eaton <jwe>
Project Administrator
Tue 05 May 2015 03:17:25 AM UTC, comment #4:

Change works for me, looks like it builds with current sndfile, and correctly disables sndfile 1.0.17 on CentOS 5.

Mike Miller <mtmiller>
Project Administrator
Sat 02 May 2015 04:41:46 AM UTC, comment #3:

I checked in a cset that at checks for a modern version of sndfile before setting HAVE_SNDFILE (http://hg.savannah.gnu.org/hgweb/octave/rev/3b3579ad7e46). More could be done, but this is probably enough.

Rik <rik5>
Project AdministratorIn charge of this item.
Fri 01 May 2015 04:32:43 PM UTC, comment #2:

The second approach, just testing for some features we need, will probably be easier. After libsnd is detected you could write a small test program for configure.ac that includes the appropriate library headers and then tries to use one of the constants.

Look in m4/acinclude.m4 for inspiration. Here is something for checking Qscintialla which I think could be used.

SW_FORMAT_OGG is an enum in sndfile.h so I don't know if you could get by with AC_PREPROC_IFELSE, or whether you actually need to use AC_COMPILE_IFELSE to compile the program too.

Rik <rik5>
Project AdministratorIn charge of this item.
Fri 01 May 2015 02:30:16 PM UTC, comment #1:

Thanks for finding this, guess I hadn't gone back and tested on CentOS 5 after we added the sound libraries!

I wouldn't call this a blocker for the 4.0.0 release, unless there are other distros with an ancient sndfile version that may also be a risk to impact a lot of users. I can take a look at this if no one else wants to, see if either I can make it work with older sndfile or add a configure.ac test for some minimal feature that we need.

Mike Miller <mtmiller>
Project Administrator
Fri 01 May 2015 11:34:55 AM UTC, original submission:

I tried to build octave 4.0.0-rc4 on CentOS 5 with libsnd 1.0.17. Although libsndfile was installed, the version was not good enough. I guess that the configure script should check for this.

The error messages I get are:

Carnë Draug <carandraug>
Project Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by jwe (Posted a comment)
  • -unavailable- added by rik5 (Posted a comment)
  • -unavailable- added by mtmiller (Posted a comment)
  • -unavailable- added by carandraug (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 6 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Tue 02 Jun 2015 04:11:02 PM UTCjweRelease4.0.0-rc4=>4.0.0
    Tue 05 May 2015 03:17:25 AM UTCmtmillerStatusReady For Test=>Fixed
      Assigned tomtmiller=>rik5
      Open/ClosedOpen=>Closed
    Sat 02 May 2015 04:41:46 AM UTCrik5StatusNone=>Ready For Test
    Fri 01 May 2015 02:30:16 PM UTCmtmillerAssigned toNone=>mtmiller

    Back to the top


    Powered by Savane 3.1-cleanup1