bugGNUstep - Bugs: bug #44933, Cairo backend: NSGraphicsContext's...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #44933: Cairo backend: NSGraphicsContext's imageInterpolation setting is ignored

Submitted by:  Josh Freeman <tedge>
Submitted on:  Mon 27 Apr 2015 04:32:32 AM UTC  
 
Category: BackendSeverity: 3 - Normal
Item Group: BugStatus: Fixed
Privacy: PublicAssigned to: Fred Kiefer <FredKiefer>
Open/Closed: Closed

Fri 22 May 2015 09:29:33 PM UTC, comment #1:

Thank you for another great patch. I just submitted it to SVN.

Fred Kiefer <FredKiefer>
Project MemberIn charge of this item.
Mon 27 Apr 2015 04:32:32 AM UTC, original submission:

Setup: VirtualBox 4.3 + Ubuntu 14.04 guest, Clang, GNUstep from current SVN trunk

Scaled images drawn with the Cairo backend are always interpolated (blurred), even when interpolation is disabled in the current NSGraphicsContext (imageInterpolation set to NSImageInterpolationNone).

This is because the CairoGState class hard-codes all calls to cairo_pattern_set_filter() (Cairo function for setting interpolation type) with the interpolation value, CAIRO_FILTER_BILINEAR.

The attached patch updates CairoGState's cairo_pattern_set_filter() calls to use an appropriate value based on the graphicsContext's imageInterpolation setting. Test program is also attached.

Josh Freeman <tedge>

 

Attached Files
file #33800:  TestImageInterpolation.m added by tedge (7KiB - text/x-objcsrc)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by FredKiefer (Posted a comment)
  • -unavailable- added by tedge (Submitted the item)
  • -unavailable- added by tedge (This might be of interest to you, since you're the developer of an imaging app (PRICE))
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 8 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sat 18 Nov 2017 02:57:01 PM UTCFredKieferStatusReady For Test=>Fixed
      Open/ClosedIn Test=>Closed
    Fri 22 May 2015 09:29:33 PM UTCFredKieferStatusNone=>Ready For Test
      Assigned toNone=>FredKiefer
      Open/ClosedOpen=>In Test
    Mon 27 Apr 2015 04:32:32 AM UTCtedgeAttached File-=>Added CairoGState_ImageInterpolation.patch, #33799
      Attached File-=>Added TestImageInterpolation.m, #33800
      Carbon-Copy-=>Added rmottola

    Back to the top


    Powered by Savane 3.1-cleanup1