Mon 04 May 2015 02:26:30 PM UTC, comment #14:
Well, the whole open/close thing is very incomplete. I commited a quick and dirty fix.
|
Mon 04 May 2015 12:02:47 PM UTC, comment #13:
One thing I have noticed:
on a closed serial port, displaying the variable:
|
Mon 04 May 2015 01:05:25 AM UTC, comment #12:
Looks like is most likely a gcc issue in mxe for win64.
See https://savannah.gnu.org/bugs/?44998
|
Thu 30 Apr 2015 12:12:07 PM UTC, comment #11:
Tried in octave-64 under windows and it crashes somewhere.
I need to rebuild with gdb to see what it is doing
|
Wed 29 Apr 2015 10:56:21 AM UTC, comment #10:
Merged. Thanks!
|
Wed 29 Apr 2015 02:16:51 AM UTC, comment #9:
Comment #7 is fixed in mercurial already.
Here is my additions included in your patch which fixed the class methods not being virtual, and prints out the serial class in a nicer format like in comment #8.
(file #33834)
|
Tue 28 Apr 2015 11:50:24 PM UTC, comment #8:
|
Tue 28 Apr 2015 11:43:16 PM UTC, comment #7:
Another issue - probally should add as a new bug report:
I just installed instrument-control on my fedora linux box, using instrument-control from octave-forge.
On running a = tcp('127.0.0.1', 10000) I get:
>> a = tcp("127.0.0.1", 10000)
a = error: octave_base_value::print (): wrong type argument 'octave_tcp'
I think I was seeing a similar issue on the windows package, and it ended up being that I needed a print function:
void print (std::ostream& os, bool pr_as_read_syntax = false)
(ie: no const)
|
Tue 28 Apr 2015 11:30:55 PM UTC, comment #6:
I haven't used the matlab instrument control before but could format similar to it [1]
Or, something similar to:
The attributes indented from the variable name, case of names consistant (whether that is all lowercase, camelcase ... )
[1] http://www.mathworks.com/help/instrument/serial-port-object.html
|
Tue 28 Apr 2015 09:58:52 PM UTC, comment #5:
I'm at war with user interfaces, so suggestions for pretty print are very welcome :)
|
Tue 28 Apr 2015 07:22:51 PM UTC, comment #4:
I see it - octave_serial_common: your methods need to be declared virtual.
|
Tue 28 Apr 2015 07:09:22 PM UTC, comment #3:
Probally a good idea.
I haven't tested in octave 64 yet, nor looked at the code, but did a quick test for Windows and octave 32 bit.
It would be better I think if the output was formatted rather than all left justified. Currently I get:
In addition, as above, isOpen and other fields are not correct? above it says it is not open? however should be, and if I attempt to open again it will fail with access denied, which is understandable as the port is open.
If I fclose(a) and redo, it works again, but still shows isOpen: 0.
So it is just not displaying correctly.
|
Tue 28 Apr 2015 02:42:11 PM UTC, comment #2:
John, thanks for reporting this bug and adding instrument-control to mxe-octave.
Using the scalar value of file descriptor/handle as output is not very useful, so I modified the print function to return serial properties as text.
What do you think of this approach? Could you check if this works with win32/win64 ?
(file #33824)
|
Thu 16 Apr 2015 06:23:41 PM UTC, comment #1:
Patch attached
(file #33693)
|
Thu 16 Apr 2015 06:20:00 PM UTC, original submission:
Package fails to build serial.oct in win64 with error casting HANDLE to int.
|