bugGNU Octave - Bugs: bug #44811, zip.m XFAIL on Windows

 
 

bug #44811: zip.m XFAIL on Windows

Submitted by:  Philip Nienhuis <philipnienhuis>
Submitted on:  Sat 11 Apr 2015 09:02:01 PM UTC  
 
Category: Octave FunctionSeverity: 3 - Normal
Priority: 5 - NormalItem Group: Incorrect Result
Status: FixedAssigned to: None
Originator Name: Philip NienhuisOpen/Closed: Closed
Release: devOperating System: Microsoft Windows

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Fri 17 Apr 2015 03:37:12 PM UTC, comment #4:

There was something wrong internally with the second patch. I did

So I just used the diff I had before, but checked it in under your name since you were the one who came one with the fix. See http://hg.savannah.gnu.org/hgweb/octave/rev/d6e523825abc.

Marking bug fixed and closing report.

Rik <rik5>
Project Administrator
Fri 17 Apr 2015 07:24:42 AM UTC, comment #3:

Hey that's what I intended.... good catch

Seems on Linux (where I do mercurial stuff) I forgot to include the
"cd (rootdir)"
command in the final version (it was included in the draft on Windows where the bug manifested itself).

Attached is a better version (simply an edited changeset)

(file #33698)

Philip Nienhuis <philipnienhuis>
Project Member
Fri 17 Apr 2015 12:32:10 AM UTC, comment #2:

The patch breaks the third argument option (rootdir) of zip. What about the attached zip.diffs instead?

(file #33697)

Rik <rik5>
Project Administrator
Sat 11 Apr 2015 09:04:49 PM UTC, comment #1:

Here's the patch

(file #33642)

Philip Nienhuis <philipnienhuis>
Project Member
Sat 11 Apr 2015 09:02:01 PM UTC, original submission:

...caused by the fact that there's a "system (<cmd>)" instruction sending two consecutive commands to the shell.
That works on *nix but not on Windows.

In addition there's a typo in the last but one test line.

changeset in the next comment (as soon as I have a bug number)

Philip Nienhuis <philipnienhuis>
Project Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #33698:  zip.m_bug44811-2.cs added by philipnienhuis (1KiB - text/x-csharp)
file #33697:  zip.diffs added by rik5 (895B - application/octet-stream)
file #33642:  zip.m_bug44811.cs added by philipnienhuis (1KiB - text/x-csharp)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by rik5 (Updated the item)
  • -unavailable- added by philipnienhuis (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 6 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Fri 17 Apr 2015 03:37:12 PM UTCrik5StatusPatch Submitted=>Fixed
      Open/ClosedOpen=>Closed
    Fri 17 Apr 2015 07:24:42 AM UTCphilipnienhuisAttached File-=>Added zip.m_bug44811-2.cs, #33698
    Fri 17 Apr 2015 12:32:10 AM UTCrik5Attached File-=>Added zip.diffs, #33697
    Sat 11 Apr 2015 09:04:49 PM UTCphilipnienhuisAttached File-=>Added zip.m_bug44811.cs, #33642
      StatusNone=>Patch Submitted

    Back to the top


    Powered by Savane 3.1-cleanup1