bugGNU nano - Bugs: bug #44790, in WhereIsFile (^R ^T ^W) some...

 
 

bug #44790: in WhereIsFile (^R ^T ^W) some keys behave strange

Submitted by:  Benno Schulenberg <bens>
Submitted on:  Thu 09 Apr 2015 10:28:39 AM UTC  
 
Severity: 3 - NormalStatus: Fixed
Assigned to: Benno Schulenberg <bens>Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sun 12 Apr 2015 09:06:17 AM UTC, comment #2:

Fixed in SVN, r5190.

Benno Schulenberg <bens>
Project AdministratorIn charge of this item.
Thu 09 Apr 2015 10:57:20 AM UTC, comment #1:

Attached patch makes the advertised keys (M-\ and M-/) do what they say, and makes the unadvertised keys (^Y, ^V and ^_) no-ops.

Okay to apply, Chris? Or do you wish to keep the ^W ^Y and ^W ^V combinations? (To be consistent with the editor, though, they would have to go to first file and last file.)

(file #33612)

Benno Schulenberg <bens>
Project AdministratorIn charge of this item.
Thu 09 Apr 2015 10:28:39 AM UTC, original submission:

Run src/nano with -IU, then type ^R ^T ^W file <Enter>. The highlight will be on Makefile. Now type ^W ^Y or ^W ^V -- the highlight will shift as if M-W was pressed. Now move the cursor a bit and type ^W M-\ -- the highlight will go back to Makefile every time. Now type ^W M-/ -- the highlight will also go back to Makefile but it will say "Serach Wrapped".

Apparently ^W M-\ and ^W M-/ go to the first file and the last file in the list (as they should) but then are followed by a search-next. And ^W ^Y and ^W ^V simply do a search next. This becomes clear when you first search for a string that isn't there.

The ^W ^Y and ^W ^V doing a search-next is harmless (and maybe even nice for the habits of some people), but ^W M-\ and ^W M-/ should not be followed by a search-next.

Benno Schulenberg <bens>
Project AdministratorIn charge of this item.

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #33612:  make-keys-behave.patch added by bens (3KiB - text/x-diff)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by bens (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 4 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sun 12 Apr 2015 09:06:17 AM UTCbensStatusNone=>Fixed
      Assigned toNone=>bens
      Open/ClosedOpen=>Closed
    Thu 09 Apr 2015 10:57:20 AM UTCbensAttached File-=>Added make-keys-behave.patch, #33612

    Back to the top


    Powered by Savane 3.1-cleanup1