bugGNU remotecontrol - Bugs: bug #44755, Error message in...

 
 

bug #44755: Error message in transactionhistory page if allowed the device is 0

Submitted by:  Wensheng XIE <wxie>
Submitted on:  Tue 07 Apr 2015 08:04:57 AM UTC  
 
Category: User InterfaceSeverity: 3 - Normal
Item Group: OperationStatus: Wont Fix
Privacy: PublicAssigned to: John Elliot V <jj5>
Originator Name: wxieOpen/Closed: Closed
Operating System: GNU/LinuxReproducibility: Every Time
OS Bit Level: 32
Resolution: 

This code will be entirely rewritten in the 2.0 branch.

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Thu 09 Apr 2015 01:01:07 PM UTC, comment #4:

Wensheng,
Your work looks solid, thank you.

John,
Please review and either integrate into the v2.0 specification or close the tickets with comments, as appropriate.

Stephen H. Dawson <shdawson>
Project Administrator
Thu 09 Apr 2015 10:10:49 AM UTC, comment #3:

Hi, Stephen:

One case of the issue is reproducible.

precondition:
web user available
iptstat database user is not available

action:
login to index page is ok
transaction page has problem - new screenshot. line 170

This is not a normal case, but should we avoid this situation?

(file #33611)

Wensheng XIE <wxie>
Project Member
Thu 09 Apr 2015 08:01:44 AM UTC, comment #2:

Hi, Stephen:

The PHP log says:
[Tue Apr 07 14:48:40 2015] [error] [client 127.0.0.1] PHP Fatal error: Call to a member function fetch_assoc() on a non-object in /var/www/remotecontrol/transactionhistory.php on line 170, referer: http://127.0.0.1:9001/index.php
[Tue Apr 07 14:48:40 2015] [debug] mod_deflate.c(700): [client 127.0.0.1] Zlib: Compressed 4115 to 1522 : URL /transactionhistory.php, referer: http://127.0.0.1:9001/index.php

The line 170 in transactionhistory.php says:
while($transrecord = $transrecords->fetch_assoc())

Normally, this is caused by a failure in line 166:
$transrecords = $dataAccess->ResultSet;

The database query failed. Because I could not reproduce this failure at the moment, we can close this issue for now.

In the future, can we add some code to catch database query failure?

Wensheng XIE <wxie>
Project Member
Tue 07 Apr 2015 12:28:45 PM UTC, comment #1:

Thank you, Wensheng.

This has not been seen before. Please look at the referenced line, 170, to learn what the code is asking for. Also, please see what your PHP error log states.

Stephen H. Dawson <shdawson>
Project Administrator
Tue 07 Apr 2015 08:04:57 AM UTC, original submission:

precondition:
version 1.1 of GNU remotecontrol
tstat_admin is assigned 0 device
open Home in Iceweasel as tstat_admin

Action:
go to transaction history page

Observation:
There is an error information displayed as in the screenshot.

Expectation:
The transaction history button should be disable for 0 device users.

Wensheng XIE <wxie>
Project Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by jj5 (Updated the item)
  • -unavailable- added by shdawson (Posted a comment)
  • -unavailable- added by wxie (Submitted the item)
  • -unavailable- added by wxie
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 10 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Thu 09 Apr 2015 03:13:21 PM UTCjj5Open/ClosedOpen=>Closed
      Resolutionnone=>This code will be entirely rewritten in the 2.0 branch.
    Thu 09 Apr 2015 01:01:07 PM UTCshdawsonAssigned toshdawson=>jj5
    Thu 09 Apr 2015 10:10:49 AM UTCwxieAttached File-=>Added error-transction-history-web.png, #33611
    Thu 09 Apr 2015 08:01:43 AM UTCwxieStatusIn Progress=>Wont Fix
      Assigned towxie=>shdawson
    Tue 07 Apr 2015 12:28:45 PM UTCshdawsonStatusNone=>In Progress
      Assigned toNone=>wxie
    Tue 07 Apr 2015 08:04:57 AM UTCwxieAttached File-=>Added Error-Transaction-History.png, #33571
      Carbon-Copy-=>Added wxie

    Back to the top


    Powered by Savane 3.1-cleanup1