bugGnash - The GNU Flash player - Bugs: bug #44636, vaapi build failure,...

 
 

bug #44636: vaapi build failure, vaapi/VaapiContext.h:87:76: error: use of deleted function

Submitted by:  Chi-Thanh Christopher Nguyen <chithanh>
Submitted on:  Thu 26 Mar 2015 02:54:18 PM UTC  
 
Category: buildSeverity: 3 - Normal
Release: masterStatus: Ready For Test
Privacy: PublicAssigned to: Bastiaan Jacques <bjacques>
Open/Closed: Open

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Thu 09 Mar 2017 10:28:43 AM UTC, comment #4:

I'm having problems if the flash plugin is not in the browser, then some important site elements may not be displayed

http://19216811-admin.com/192-168-l-254/

-X- <jonnybravo>
Wed 09 Sep 2015 07:36:29 PM UTC, comment #3:

Compilation should be fixed in f5016cc9399.

Bastiaan Jacques <bjacques>
Project MemberIn charge of this item.
Wed 01 Apr 2015 01:49:50 AM UTC, comment #2:

That fixed the build error in VaapiGlobalContext.cpp, but later it will hit another problem in gtk_glue_agg_vaapi.cpp:

gtk/gtk_glue_agg_vaapi.cpp: In member function ‘gnash::VaapiVideoWindow* gnash::GtkAggVaapiGlue::getVideoWindow(std::shared_ptr<gnash::VaapiSurface>, GdkWindow*, const gnash::VaapiRectangle&)’:
gtk/gtk_glue_agg_vaapi.cpp:308:37: error: use of deleted function ‘std::unique_ptr<_Tp, _Dp>::unique_ptr(const std::unique_ptr<_Tp, _Dp>&) [with _Tp = gnash::VaapiContextData; _Dp = std::default_delete<gnash::VaapiContextData>]’
context->setData(contextData);
^
In file included from /usr/lib/gcc/x86_64-pc-linux-gnu/4.9.2/include/g++-v4/memory:81:0,
from /usr/include/boost/config/no_tr1/memory.hpp:21,
from /usr/include/boost/smart_ptr/shared_ptr.hpp:27,
from /usr/include/boost/shared_ptr.hpp:17,
from /usr/include/boost/format/alt_sstream.hpp:21,
from /usr/include/boost/format/internals.hpp:23,
from /usr/include/boost/format.hpp:38,
from ../libbase/log.h:31,
from gtk/gtk_glue_agg_vaapi.cpp:24:
/usr/lib/gcc/x86_64-pc-linux-gnu/4.9.2/include/g++-v4/bits/unique_ptr.h:356:7: note: declared here
unique_ptr(const unique_ptr&) = delete;
^
In file included from gtk/gtk_glue_agg_vaapi.cpp:35:0:
../libdevice/vaapi/VaapiContext.h:87:10: error: initializing argument 1 of ‘void gnash::VaapiContext::setData(std::unique_ptr<gnash::VaapiContextData>)’
void setData(std::unique_ptr<VaapiContextData> user_data) { _user_data = std::move(us
^
Makefile:2824: recipe for target 'gtk_gnash-gtk_glue_agg_vaapi.o' failed

Gentoo toolchain by default enables pie, stack-protector, FORTIFY_SOURCE=2 and full relro.

Chi-Thanh Christopher Nguyen <chithanh>
Thu 26 Mar 2015 08:18:52 PM UTC, comment #1:

Should be fixed in e5c08131abde1.

By the way, I would advise you to specify --enable-harden (which is the default) to configure, particularly if Gnash is used to interpret untrusted content.

Bastiaan Jacques <bjacques>
Project MemberIn charge of this item.
Thu 26 Mar 2015 02:54:18 PM UTC, original submission:

vaapi build fails on Gentoo with the following error: (git checkout from today)

In file included from vaapi/VaapiContext.cpp:23:0:
vaapi/VaapiContext.h: In member function ‘void gnash::VaapiContext::setData(std::unique_ptr<gnash::VaapiContextData>)’:
vaapi/VaapiContext.h:87:76: error: use of deleted function ‘std::unique_ptr<_Tp, _Dp>& std::unique_ptr<_Tp, _Dp>::operator=(const std::unique_ptr<_Tp, _Dp>&) [with _Tp = gnash::VaapiContextData; _Dp = std::default_delete<gnash::VaapiContextData>]’
d setData(std::unique_ptr<VaapiContextData> user_data) { _user_data = user_data
^
In file included from /usr/lib/gcc/x86_64-pc-linux-gnu/4.9.2/include/g++-v4/memory:81:0,
from /usr/include/boost/config/no_tr1/memory.hpp:21,
from /usr/include/boost/smart_ptr/shared_ptr.hpp:27,
from /usr/include/boost/shared_ptr.hpp:17,
from /usr/include/boost/format/alt_sstream.hpp:21,
from /usr/include/boost/format/internals.hpp:23,
from /usr/include/boost/format.hpp:38,
from vaapi/VaapiContext.cpp:20:
/usr/lib/gcc/x86_64-pc-linux-gnu/4.9.2/include/g++-v4/bits/unique_ptr.h:357:19: note: declared here
unique_ptr& operator=(const unique_ptr&) = delete;
^
vaapi/VaapiGlobalContext.cpp: In constructor ‘gnash::VaapiGlobalContext::VaapiGlobalContext(std::unique_ptr<gnash::VaapiDisplay>)’:
vaapi/VaapiGlobalContext.cpp:36:23: error: use of deleted function ‘std::unique_ptr<_Tp, _Dp>::unique_ptr(const std::unique_ptr<_Tp, _Dp>&) [with _Tp = gnash::VaapiDisplay; _Dp = std::default_delete<gnash::VaapiDisplay>]’
: _display(display)
^
In file included from /usr/lib/gcc/x86_64-pc-linux-gnu/4.9.2/include/g++-v4/memory:81:0,
from /usr/include/boost/config/no_tr1/memory.hpp:21,
from /usr/include/boost/smart_ptr/shared_ptr.hpp:27,
from /usr/include/boost/shared_ptr.hpp:17,
from /usr/include/boost/format/alt_sstream.hpp:21,
from /usr/include/boost/format/internals.hpp:23,
from /usr/include/boost/format.hpp:38,
from ../libbase/log.h:31,
from vaapi/VaapiGlobalContext.cpp:24:
/usr/lib/gcc/x86_64-pc-linux-gnu/4.9.2/include/g++-v4/bits/unique_ptr.h:356:7: note: declared here
unique_ptr(const unique_ptr&) = delete;
^
vaapi/VaapiGlobalContext.cpp: In static member function ‘static gnash::VaapiGlobalContext* gnash::VaapiGlobalContext::get()’:
vaapi/VaapiGlobalContext.cpp:148:66: error: use of deleted function ‘std::unique_ptr<_Tp, _Dp>::unique_ptr(const std::unique_ptr<_Tp, _Dp>&) [with _Tp = gnash::VaapiDisplay; _Dp = std::default_delete<gnash::VaapiDisplay>]’
vaapi_global_context.reset(new VaapiGlobalContext(dpy));
^
In file included from /usr/lib/gcc/x86_64-pc-linux-gnu/4.9.2/include/g++-v4/memory:81:0,
from /usr/include/boost/config/no_tr1/memory.hpp:21,
from /usr/include/boost/smart_ptr/shared_ptr.hpp:27,
from /usr/include/boost/shared_ptr.hpp:17,
from /usr/include/boost/format/alt_sstream.hpp:21,
from /usr/include/boost/format/internals.hpp:23,
from /usr/include/boost/format.hpp:38,
from ../libbase/log.h:31,
from vaapi/VaapiGlobalContext.cpp:24:
/usr/lib/gcc/x86_64-pc-linux-gnu/4.9.2/include/g++-v4/bits/unique_ptr.h:356:7: note: declared here
unique_ptr(const unique_ptr&) = delete;
^
vaapi/VaapiGlobalContext.cpp:35:1: error: initializing argument 1 of ‘gnash::VaapiGlobalContext::VaapiGlobalContext(std::unique_ptr<gnash::VaapiDisplay>)’
VaapiGlobalContext::VaapiGlobalContext(std::unique_ptr<VaapiDisplay> display)
^
Makefile:1354: recipe for target 'libgnashvaapi_la-VaapiContext.lo' failed
make[2]: *** [libgnashvaapi_la-VaapiContext.lo] Error 1

Chi-Thanh Christopher Nguyen <chithanh>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #33460:  build.log added by chithanh (55KiB - text/comma-separated-values)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by jonnybravo (Posted a comment)
  • -unavailable- added by bjacques (Updated the item)
  • -unavailable- added by chithanh (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 3 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Thu 26 Mar 2015 08:18:52 PM UTCbjacquesStatusNone=>Ready For Test
    Thu 26 Mar 2015 03:30:55 PM UTCbjacquesAssigned toNone=>bjacques
    Thu 26 Mar 2015 02:54:18 PM UTCchithanhAttached File-=>Added build.log, #33460

    Back to the top


    Powered by Savane 3.1-cleanup1